Skip to content

iter56 cluster-929: 删 AppScopedWorkflowService obsolete compat wrappers (-968 LOC)#930

Merged
loning merged 1 commit into
auto-refact-devfrom
refactor/iter56-cluster-929-studio-workflow-obsolete-shims
May 23, 2026
Merged

iter56 cluster-929: 删 AppScopedWorkflowService obsolete compat wrappers (-968 LOC)#930
loning merged 1 commit into
auto-refact-devfrom
refactor/iter56-cluster-929-studio-workflow-obsolete-shims

Conversation

@loning
Copy link
Copy Markdown
Contributor

@loning loning commented May 23, 2026

摘要

iter56 cluster-929 — audit-iter-62 no-design,直接 implement:

  • AppScopedWorkflowService obsolete compat wrappers:ListAsync / GetAsync / SaveDraftAsync(public legacy)
  • dead support:backend HTTP fallback / runtime/binding/artifact fallback dependencies / legacy DTO conversion helpers
  • 更新 DI + direct test callers 走 draft methods
  • 加 public-surface test 验证 obsolete methods 已删

边界

  • 不动 workflow draft semantics / storage contracts / service lifecycle
  • 完整体现 "删除优于兼容" 原则

影响范围

5 files changed,LOC +63 / -1031 net -968(大 cleanup!)

验证

  • dotnet build aevatar.slnx --nologo PASS
  • dotnet test aevatar.slnx --nologo PASS
  • bash tools/ci/test_stability_guards.sh PASS
  • bash tools/ci/architecture_guards.sh PASS
  • targeted Studio/CLI tests PASS

Closes #929

🤖 Auto-loop / codex-refactor-loop iter56

⟦AI:AUTO-LOOP⟧

audit-iter-62 cluster-062-studio-workflow-obsolete-compat-shims(no design,直接 implement):

- 删 AppScopedWorkflowService 的 ListAsync / GetAsync / SaveDraftAsync(public legacy) obsolete wrappers
- 删 dead support:backend HTTP fallback / runtime/binding/artifact fallback dep / legacy DTO conversion helpers
- 更新 DI + direct test callers 走 draft methods
- 加 public-surface test 验证 obsolete methods 已删

不动 workflow draft semantics / storage / lifecycle
"删除优于兼容" 落实

local PASS:dotnet build + test + test_stability + architecture + Studio/CLI tests

⟦AI:AUTO-LOOP⟧
@loning
Copy link
Copy Markdown
Contributor Author

loning commented May 23, 2026

📊 状态卡片 — reviewer 派出

维度
阶段 派出 codex(role=reviewer)
codex log review-pr930-omnibus-r1.log
工作目录 /Users/auric/aevatar
timeout 5400s(~90 min 上限)
上下文 omnibus r1 派出(-968 LOC cleanup,删 obsolete wrappers + dead support)
下一步自动会做 1. 三 reviewer 完成 verdict marker 2. controller 计算 consensus 3. unanimous → auto-merge / reject → fix r<N+1>
是否需要人介入 ❌ 否(自动推进)

🤖 controller status banner

⟦AI:AUTO-LOOP⟧

@loning
Copy link
Copy Markdown
Contributor Author

loning commented May 23, 2026

📊 codex 进展 review-pr930-omnibus-r1 (⏳ 进行中; 已跑 7 min)

I’d approve this PR. `AppScopedWorkflowService` public surface is narrowed to draft operations only; the old `ListAsync/GetAsync/SaveDraftAsync` shims and their HTTP/runtime fallback support are gone, and DI no longer wires runtime/query/artifact dependencies into that service. The new reflection test verifies those obsolete methods stay deleted.

Verification:
- `dotnet test aevatar.slnx --nologo` passed. Studio: 604 passed. CLI: 494 passed.
- `bash tools/ci/test_stability_guards.sh` passed.
- `bash tools/ci/architecture_guards.sh` passed.
- `git diff --check origin/auto-refact-dev...HEAD` passed.

Note: `$REPO_ROOT` was unset in this shell, so the literal requested guard commands first expanded to `/tools/...`; I reran the same scripts by relative path from the repo root.

REVIEW_DONE:930:omnibus:approve
⟦AI:AUTO-LOOP⟧
tokens used
88,212
Findings: none.

I’d approve this PR. `AppScopedWorkflowService` public surface is narrowed to draft operations only; the old `ListAsync/GetAsync/SaveDraftAsync` shims and their HTTP/runtime fallback support are gone, and DI no longer wires runtime/query/artifact dependencies into that service. The new reflection test verifies those obsolete methods stay deleted.

Verification:
- `dotnet test aevatar.slnx --nologo` passed. Studio: 604 passed. CLI: 494 passed.
- `bash tools/ci/test_stability_guards.sh` passed.
- `bash tools/ci/architecture_guards.sh` passed.
- `git diff --check origin/auto-refact-dev...HEAD` passed.

Note: `$REPO_ROOT` was unset in this shell, so the literal requested guard commands first expanded to `/tools/...`; I reran the same scripts by relative path from the repo root.

自动更新每 10 分钟;edit-in-place 不堆评论;codex 完成后此 comment 自动删除(per Auric "完成后删掉就好了 否则太占空间")。
🤖 controller progress reporter

@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.52%. Comparing base (b4070cc) to head (fa9c2f3).

@@               Coverage Diff                @@
##           auto-refact-dev     #930   +/-   ##
================================================
  Coverage            83.52%   83.52%           
================================================
  Files                  991      991           
  Lines                63678    63678           
  Branches              8232     8232           
================================================
+ Hits                 53184    53190    +6     
+ Misses                6933     6931    -2     
+ Partials              3561     3557    -4     
Flag Coverage Δ
ci 83.52% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loning loning merged commit 663ad0e into auto-refact-dev May 23, 2026
12 checks passed
@loning
Copy link
Copy Markdown
Contributor Author

loning commented May 23, 2026

📊 codex 进展 bootstrap-audit-63-issues (⏳ 进行中; 已跑 2 min)

- 不修改 NyxID 行为。
- 不新增 channel registration 产品能力。
- 不重新设计 registration provisioning 主流程。

## design_question

Channel registration 的投影重建是否还需要线上手动入口?如果需要,它应该只存在于哪一个维护边界里,并用什么权限/审计语义保护?

⟦AI:AUTO-LOOP⟧
EOF' in /Users/auric/aevatar
 succeeded in 2003ms:
https://github.com/aevatarAI/aevatar/issues/933

codex
BOOTSTRAP_DONE:audit-iter-63:opened-1:skipped-0

新 issue:#933  
https://github.com/aevatarAI/aevatar/issues/933

已完成去重检查:#931/#932、#923/#924/#926/#930、audit-56 到 audit-62 均无重叠。
tokens used
57,932
BOOTSTRAP_DONE:audit-iter-63:opened-1:skipped-0

新 issue:#933  

自动更新每 10 分钟;edit-in-place 不堆评论;codex 完成后此 comment 自动删除(per Auric "完成后删掉就好了 否则太占空间")。
🤖 controller progress reporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant