Skip to content

Conversation

@tkkuehn
Copy link
Collaborator

@tkkuehn tkkuehn commented Sep 15, 2021

Proposed changes

The deploy action uses a cached environment, and the key to that cache is currently based on the hash of requirements.txt. Because of the change to requirements.txt in #145, that file no longer works as a key for the cache, so this PR sets it up to use setup.py instead.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionalitiy)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through black with the -l 79 flag.
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

PR template was adopted from appium

@tkkuehn tkkuehn requested a review from kaitj September 15, 2021 19:14
@tkkuehn tkkuehn temporarily deployed to TEST September 15, 2021 19:15 Inactive
@tkkuehn tkkuehn temporarily deployed to TEST September 15, 2021 19:17 Inactive
@github-actions github-actions bot requested a review from ostanley September 15, 2021 19:17
@kaitj
Copy link
Collaborator

kaitj commented Sep 15, 2021

LGTM! Rerunning ensured cache was properly too - merging!

@kaitj kaitj merged commit f58afcc into master Sep 15, 2021
@kaitj kaitj deleted the fix-actions-cache branch September 15, 2021 19:18
@kaitj kaitj temporarily deployed to TEST September 15, 2021 19:18 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants