Skip to content

rename master builds to aframe-master* (fixes #2007)#2082

Merged
dmarcos merged 4 commits intoaframevr:masterfrom
ngokevin:releasescripts
Nov 13, 2016
Merged

rename master builds to aframe-master* (fixes #2007)#2082
dmarcos merged 4 commits intoaframevr:masterfrom
ngokevin:releasescripts

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented Nov 10, 2016

  • aframe* to aframe-master*
  • Release script to automatically copy/rename the master builds to new stable version as well as update documentation and README.

@dmarcos
Copy link
Member

dmarcos commented Nov 11, 2016

Should it be aframe-dev or aframe-master? That way is it's easy to know where they can from

@ngokevin
Copy link
Member Author

I initially thought master in the issue, but I thought dev would be more clear on what it was in terms of instability. "dev build" vs. "master build".

@dmarcos
Copy link
Member

dmarcos commented Nov 11, 2016

@fernandojsg @feiss what do you think? Using aframe-dev.js or aframe-master.js? One indicates the development nature of the build and the other the branch where it was generated from.

@dmarcos
Copy link
Member

dmarcos commented Nov 11, 2016

Can we automate the generation of these builds per commit?

@ngokevin
Copy link
Member Author

ngokevin commented Nov 11, 2016

Yeah. We could do it nightly maybe? If so, that opens up aframe-nightly.js, which indicates that it will change nightly and is unstable.

@dmarcos
Copy link
Member

dmarcos commented Nov 11, 2016

My preference is aframe-master.js , always in sync with the latest commit. I believe is clear enough since all github repos have a master branch.

@ngokevin
Copy link
Member Author

I don't have a strong preference. When I link people to it, I'll be linking to a heading in the README that'll explain it.

@dmarcos
Copy link
Member

dmarcos commented Nov 11, 2016

If we use master it will also be consistent with the release versions aframe-v0.4.0 and the git tags v0.4.0. You can just do git checkout build-suffix to see the code

@ngokevin
Copy link
Member Author

Updated

@ngokevin ngokevin changed the title rename master builds to aframe-dev* (fixes #2007) rename master builds to aframe-master* (fixes #2007) Nov 12, 2016
@dmarcos dmarcos merged commit 700f413 into aframevr:master Nov 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants