Add minFilter and magFilter to material component replacing npot#5717
Add minFilter and magFilter to material component replacing npot#5717dmarcos merged 1 commit intoaframevr:masterfrom
Conversation
|
PR ended pretty big |
Not really? The majority is the auto-generated attribute tables for primitives in the docs. Kind of unavoidable when material properties change. The actual changes are minimal: |
|
I verified with some console.log that by default on a texture we have so here the default on the minFilter and magFilter properties in this PR matches that and just setting minFilter to linear indeed does the same thing than the previous code. Also I confirm this is still needed to set minFilter here. So the changes in the PR looks good to me. Thanks for the work @mrxz |
|
Thanks! |
Description:
As discussed in #5706 the
npotproperty was only intended for working with non-power-of-two textures in WebGL 1. It's being used in several places to indirectly set theminFiltertoTHREE.LinearFiltering. This PR introducesminFilterandmagFilterproperties allowing the filtering methods to be set directly and explicitly.Changes proposed:
minFilterandmagFilterproperties tomaterialcomponent to set texture filtering.npotproperty frommaterialcomponent