Expose premultipliedAlpha on material component#5810
Merged
dmarcos merged 1 commit intoaframevr:masterfrom Apr 12, 2026
Merged
Conversation
Since three.js r178, THREE.MultiplyBlending emits a repeated console warning unless material.premultipliedAlpha is true. Expose premultipliedAlpha as a material schema property and force it on whenever blending is multiply. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since three.js r178 (mrdoob/three.js#31246),
THREE.MultiplyBlendingemits a repeated console warning unless the material haspremultipliedAlpha = true:A-Frame's
materialcomponent exposesblending: multiplybut does not exposepremultipliedAlpha, so users had no way to silence the warning from markup alone.This PR:
premultipliedAlphato thematerialschema (defaultfalse), giving users direct control from markup.premultipliedAlpha = truewheneverblendingismultiply, regardless of the user-supplied value, so the three.js warning cannot accidentally be triggered through the component's public API.Changes
src/components/material.js— addpremultipliedAlphaschema property; force it on forblending: multiply, otherwise pass through the user value.docs/components/material.md— document the new property.tests/components/material.test.js— four tests in theblendingsuite covering:Test plan
npm test— all tests pass.material="blending: multiply; transparent: true".