afup#1499 Récupération des meetups via GraphQL#1592
Merged
stakovicz merged 1 commit intoafup:masterfrom Feb 13, 2025
Merged
Conversation
Mopolo
force-pushed
the
meetup-graphql
branch
5 times, most recently
from
a9e029f to
38e0380
Compare
Mopolo
force-pushed
the
meetup-graphql
branch
from
38e0380 to
5b4e5ba
Compare
agallou
approved these changes
Feb 13, 2025
agallou
reviewed
Feb 13, 2025
stakovicz
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cette PR remplace le scraping des pages HTML par un appel à l'API GraphQL de Meetup.
Il n'y a qu'un seul appel pour toutes les antennes en une fois. Et on peut à nouveau récupérer la description et le lieu de chaque évènement.
La PR ajoute une dépendance sur cuyz/valinor pour parser la réponse JSON en DTOs. On s'en sert déjà sur planete-php donc pas de risque et la lib est déjà compatible avec PHP 8.4 donc ça ne posera pas de soucis.
Et j'aime toujours pas atoum