Skip to content

Add force follow-up request flow#22

Merged
afurm merged 1 commit intomainfrom
af/force-follow-up
May 6, 2026
Merged

Add force follow-up request flow#22
afurm merged 1 commit intomainfrom
af/force-follow-up

Conversation

@afurm
Copy link
Copy Markdown
Owner

@afurm afurm commented May 6, 2026

Summary

  • keep the task composer to a single Send action while active work is running
  • show Force request on queued follow-up bubbles so users can promote a queued request
  • add server support to promote the existing queued follow-up execution, cancel older active/queued work, and avoid duplicate forced executions

Validation

  • npm run typecheck
  • npm test
  • npm run build
  • desktop and mobile render checks via Chrome CDP fallback

@afurm afurm marked this pull request as ready for review May 6, 2026 15:35
@afurm afurm merged commit 1acc2b4 into main May 6, 2026
2 checks passed
@chatgpt-codex-connector
Copy link
Copy Markdown

💡 Codex Review

if (execution.requestKind !== "follow_up" || execution.status !== "queued") {
return {
found: true,
forced: false,
reason: "Only queued follow-ups can be forced.",

P1 Badge Restrict force to latest queued follow-up

forceQueuedTaskFollowUpExecutionForTask currently accepts any queued follow-up, not just the newest one. If two follow-ups are queued behind an active run and the user forces the older one, this code cancels the newer execution via cancelAbortableExecutions and runs the older execution with its original timestamp; because task “current execution” is selected by newest createdAt (see BoardStore.getLatestTaskExecutionWithHistory), the cancelled newer execution remains task.execution even after the forced run succeeds, so clients can show the task as cancelled and miss the successful forced output. Repro: queue follow-up A, queue follow-up B, then force A.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant