Skip to content

Clean launch rough edges: artifacts optional imports docs extras smok…#45

Merged
bordeauxred merged 1 commit into
mainfrom
enhancement/issue-29-clean-launch-rough-edges-artifacts-optional-imports-docs-extras-smoke-script
Apr 19, 2026
Merged

Clean launch rough edges: artifacts optional imports docs extras smok…#45
bordeauxred merged 1 commit into
mainfrom
enhancement/issue-29-clean-launch-rough-edges-artifacts-optional-imports-docs-extras-smoke-script

Conversation

@tianyibigdata
Copy link
Copy Markdown
Collaborator

Prepare the repository for a cleaner public launch by removing avoidable friction in packaging, imports, docs, examples, and release verification. The goal is to ensure first-time users can install, import, run examples, and build docs/releases reliably with minimal support overhead.

@tianyibigdata tianyibigdata self-assigned this Apr 19, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Makefile to standardize development workflows, a smoke.sh script for pre-release validation, and lazy loading for environment adapters to optimize imports. It also updates project dependencies and documentation. Feedback suggests expanding the syntax check in the Makefile to cover the entire package and refining the smoke.sh script to ensure clean builds and consistent execution within the managed environment using uv for building and auditing.

Comment thread Makefile Outdated
Comment thread scripts/smoke.sh Outdated
Comment thread scripts/smoke.sh Outdated
Comment thread scripts/smoke.sh Outdated
Comment thread scripts/smoke.sh Outdated
@tianyibigdata tianyibigdata force-pushed the enhancement/issue-29-clean-launch-rough-edges-artifacts-optional-imports-docs-extras-smoke-script branch from 5b3027d to b80f805 Compare April 19, 2026 18:32
@bordeauxred
Copy link
Copy Markdown
Contributor

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Makefile to standardize development tasks, adds a smoke.sh script for pre-release validation, and implements lazy loading for environment adapters in clawloop/environments/__init__.py. It also updates project metadata and documentation. Feedback includes addressing a git dependency in pyproject.toml that is incompatible with PyPI, optimizing the lazy loading mechanism by caching imported attributes, and improving the robustness of the smoke test script's wheel detection.

Comment thread pyproject.toml Outdated
Comment thread clawloop/environments/__init__.py
Comment thread scripts/smoke.sh Outdated
@tianyibigdata tianyibigdata force-pushed the enhancement/issue-29-clean-launch-rough-edges-artifacts-optional-imports-docs-extras-smoke-script branch 2 times, most recently from 4da98ff to e421d20 Compare April 19, 2026 19:36
…e script

Signed-off-by: getianyi <getianyi602@gmail.com>
@tianyibigdata tianyibigdata force-pushed the enhancement/issue-29-clean-launch-rough-edges-artifacts-optional-imports-docs-extras-smoke-script branch from e421d20 to 413f5c2 Compare April 19, 2026 19:40
@bordeauxred bordeauxred merged commit 62358f1 into main Apr 19, 2026
4 checks passed
@bordeauxred bordeauxred deleted the enhancement/issue-29-clean-launch-rough-edges-artifacts-optional-imports-docs-extras-smoke-script branch April 19, 2026 19:55
@tianyibigdata tianyibigdata restored the enhancement/issue-29-clean-launch-rough-edges-artifacts-optional-imports-docs-extras-smoke-script branch April 19, 2026 19:57
bordeauxred pushed a commit that referenced this pull request May 22, 2026
…e script (#45)

Signed-off-by: getianyi <getianyi602@gmail.com>
Prepare the repository for a cleaner public launch by removing avoidable friction in packaging, imports, docs, examples, and release verification. The goal is to ensure first-time users can install, import, run examples, and build docs/releases reliably with minimal support overhead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean launch rough edges: artifacts, optional imports, docs extras, smoke script

2 participants