Skip to content
This repository was archived by the owner on Sep 21, 2020. It is now read-only.

Conversation

@agateau
Copy link
Owner

@agateau agateau commented Aug 15, 2018

  • Port from distutils to setuptools (was about time!)
  • Replace relative imports with absolute imports
  • Rename doxyqml/doxyqml.py to doxyqml/main.py to avoid confusions
  • Remove the bin/doxyqml and bin/fromsrc.py since they are no longer needed
    with setuptools

This should fix #32

- Port from distutils to setuptools (was about time!)
- Replace relative imports with absolute imports
- Rename doxyqml/doxyqml.py to doxyqml/main.py to avoid confusions
- Remove the bin/doxyqml and bin/fromsrc.py since they are no longer needed
  with setuptools
This is necessary now that we don't have the bin/ dir hack
@coveralls
Copy link

coveralls commented Aug 15, 2018

Pull Request Test Coverage Report for Build 64

  • 4 of 8 (50.0%) changed or added relevant lines in 3 files are covered.
  • 68 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-8.6%) to 79.34%

Changes Missing Coverage Covered Lines Changed/Added Lines %
doxyqml/main.py 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
doxyqml/qmlparser.py 23 75.69%
doxyqml/qmlclass.py 45 61.79%
Totals Coverage Status
Change from base Build 50: -8.6%
Covered Lines: 1371
Relevant Lines: 1728

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 60

  • 4 of 8 (50.0%) changed or added relevant lines in 3 files are covered.
  • 68 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-31.7%) to 56.25%

Changes Missing Coverage Covered Lines Changed/Added Lines %
doxyqml/main.py 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
doxyqml/qmlparser.py 23 75.69%
doxyqml/qmlclass.py 45 61.79%
Totals Coverage Status
Change from base Build 50: -31.7%
Covered Lines: 243
Relevant Lines: 432

💛 - Coveralls

@mpaperno
Copy link
Contributor

Worked well for me! 👍 I pulled the branch, and just ran setup.py from the repo root folder. Only minor confusion for me was that it now installs in Scripts folder.

I had to add the python Scripts folder to my PATH, but maybe that's a default option during python install anyway, really not sure at this point (many Python installs over the years).

Run coverage in the test dirs. Not sure why it's required, but without it
we end up with this message when combining:

    Coverage.py warning: No data was collected. (no-data-collected)
@agateau
Copy link
Owner Author

agateau commented Aug 15, 2018

Yes, I think the Scripts folder is in %PATH% by default, but that is worth adding to the README. Will do so.

@agateau agateau merged commit 58942f1 into master Aug 26, 2018
@agateau agateau deleted the fix-windows branch August 26, 2018 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doxyqml error

4 participants