Skip to content
This repository was archived by the owner on Sep 21, 2020. It is now read-only.

Conversation

@JohannesSchilling
Copy link
Contributor

We were not using the version-info in a project at work, so i added an option to not generate them in the first place. Keeping the default to the current behaviour, i thought maybe upstream could want this change as well.

@coveralls
Copy link

coveralls commented Apr 10, 2019

Pull Request Test Coverage Report for Build 103

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 42 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.05%) to 89.333%

Files with Coverage Reduction New Missed Lines %
/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/doxyqml-0.5.0-py3.5.egg/doxyqml/main.py 14 68.22%
/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/doxyqml-0.5.0-py3.6.egg/doxyqml/main.py 14 68.22%
/home/travis/virtualenv/python3.4.6/lib/python3.4/site-packages/doxyqml-0.5.0-py3.4.egg/doxyqml/main.py 14 68.22%
Totals Coverage Status
Change from base Build 102: 0.05%
Covered Lines: 1072
Relevant Lines: 1200

💛 - Coveralls

@agateau
Copy link
Owner

agateau commented Apr 14, 2019

Looks good, thanks!

Can you add a functional test for this option? I just added support for testing command line arguments to Doxyqml functional test "framework". It's documented in https://github.com/agateau/doxyqml/blob/master/tests/functional/README.md.

You can start from the "namespace" test as an example.

@JohannesSchilling
Copy link
Contributor Author

rebased onto latest master and added a functional test to test the absence of the "Since: .." version entry.

@agateau
Copy link
Owner

agateau commented Apr 28, 2019

Sorry for the delay, looks great now, merging it. Thanks again!

@agateau agateau merged commit 6481a72 into agateau:master Apr 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants