-
Notifications
You must be signed in to change notification settings - Fork 259
[ fix ] Relation.Nullary.Decidable.Core names for combinators
#2843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for that. Wondering whether there are a few more opportunities for consistent naming.
| ... | inj₂ y₁∼x₁ | inj₂ y₂∼x₂ = inj₂ ( y₁∼x₁ , y₂∼x₂) | ||
| ... | inj₂ y₁∼x₁ | inj₁ x₂∼y₂ = inj₁ (sym₁ y₁∼x₁ , x₂∼y₂) | ||
|
|
||
| ×-decidable : Decidable R → Decidable S → Decidable (Pointwise R S) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be called pointwise??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arguably! But see above below...
|
|
||
| ×-decidable : Decidable _≈₁_ → Decidable _<₁_ → Decidable _<₂_ → | ||
| Decidable _<ₗₑₓ_ | ||
| ×-decidable dec-≈₁ dec-<₁ dec-≤₂ x y = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be called <ₗₑₓ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
| ∷-injective : x ∷ xs ≡ y ∷ ys → x ≡ y × xs ≡ ys | ||
| ∷-injective refl = refl , refl | ||
|
|
||
| ≡-dec : DecidableEquality A → DecidableEquality (Vec A n) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be called ≡??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto. (this one seems especially egregious, given that conventionally, we make the different choice of _≟_ instead... one reason I wanted to leave this alone, until we could agree a/the 'blessed'/'right' name!) #2845
|
|
||
| module _ {L : REL A B ℓ₁} {R : REL A B ℓ₂} where | ||
|
|
||
| decidable : Decidable L → Decidable R → Decidable (L ∩ R) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be called _∩?_?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed.
yes, hence the OP reference to "lots of other occurrences of I already encountered the need for some careful qualified importing in order to avoid name clashes, and I didn't want to get into deeper rabbit holes by widening the impact of this PR.
|
Fixes #2842
Issues:
-decas a suffix which could/should be changed to?