-
Notifications
You must be signed in to change notification settings - Fork 260
[ fix ] the test runner for v2.0-joss-submission #2884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2.0-joss-submission
Are you sure you want to change the base?
[ fix ] the test runner for v2.0-joss-submission #2884
Conversation
Now that this is sorted, the other ones should be easy
Some cleanups based on this new use-case
|
Wow this looks hairy. Thanks so much @gallais! Let me know when we can merge this in... |
|
I'll polish it this afternoon (specifically the part documenting what needs to |
Making it more interesting than two "her" matches
|
CI work is hell Unfortunately did not have time to finish it today. I'm busy tomorrow & then |
|
Nevermind, it looks like continuing to hack while watching Limmy's show did deliver! 🥳 |
JacquesCarette
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hero work! Looks fantastic.
|
Heroic refactoring! |
Yes, I tried to design it so that it could be easily upgraded & extended to the new tests
I think it was a good thunk-forcing function for stuff we should have done a while ago |
|
Re: resources. I'd been thinking of the human ones, much more than the machine ones, but yes... ;-) |
Unfortunately we never worried about pinning down the versioning story
and agda makes that quite difficult.
I am hand-writing cabal files for these. We should then port these changes
over to the main branch, with updated bounds to be able to use more modern
versions of GHC & accompanying packages.
This now works when calling
AGDA_EXEC=agda-2.6.4 GHC_EXEC=ghc-9.2.8 make testsuitecabalfile rigmarole)