Merged
Conversation
flupe
reviewed
Apr 6, 2023
flupe
approved these changes
Apr 6, 2023
Contributor
flupe
left a comment
flupe
left a comment
There was a problem hiding this comment.
This is a really neat solution!
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #142 by enforcing that there are no dot patterns in the functions we compile to Haskell, even in implicit (type) arguments. To make this work, I also had to add a check that type parameters that appear in the Haskell code are not marked with
@0(which was already the case for datatypes, but not yet for functions).