Merged
Conversation
Owner
|
@GuilhermeFernandes01 Seems to be a package.json conflict :P |
ageddesi
previously approved these changes
Oct 9, 2022
Owner
|
HI @GuilhermeFernandes01 can you delete package-lock.json and node modules then re-run npm instal. This should resolve the conflicts and then ready to pull add tag with that sexy hacktober-accepted :P |
Contributor
Author
|
Hey @ageddesi sorry for the delay, merge problems fixed. |
ageddesi
approved these changes
Oct 11, 2022
Owner
|
Thanks. Appreciate the work on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ageddesi! Relates to #159.
PS: coverage report is not working for routes files by the way it is implemented.