Skip to content

feat: la liga teams endpoint#185

Merged
ageddesi merged 5 commits intoageddesi:devfrom
GuilhermeFernandes01:dev
Oct 11, 2022
Merged

feat: la liga teams endpoint#185
ageddesi merged 5 commits intoageddesi:devfrom
GuilhermeFernandes01:dev

Conversation

@GuilhermeFernandes01
Copy link
Contributor

Hi @ageddesi! Relates to #159.

  • Add la liga endpoint
  • Create helper to get random subarray, which will be useful to many other routes
  • Add tests to la liga endpoint
  • Add jest coverage report (which I think is very useful)
  • Add supertest types

PS: coverage report is not working for routes files by the way it is implemented.

@ageddesi
Copy link
Owner

ageddesi commented Oct 9, 2022

@GuilhermeFernandes01 Seems to be a package.json conflict :P

ageddesi
ageddesi previously approved these changes Oct 9, 2022
@ageddesi
Copy link
Owner

ageddesi commented Oct 9, 2022

HI @GuilhermeFernandes01 can you delete package-lock.json and node modules then re-run npm instal.

This should resolve the conflicts and then ready to pull add tag with that sexy hacktober-accepted :P

@GuilhermeFernandes01
Copy link
Contributor Author

Hey @ageddesi sorry for the delay, merge problems fixed.

@ageddesi ageddesi merged commit 471f592 into ageddesi:dev Oct 11, 2022
@ageddesi
Copy link
Owner

Thanks. Appreciate the work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants