Added album to music api with album data#73
Merged
ageddesi merged 2 commits intoageddesi:v.0.13.0from Oct 2, 2022
Merged
Conversation
ageddesi
reviewed
Oct 2, 2022
modules/music/api/music-routes.ts
Outdated
| song: string | ||
| } | ||
|
|
||
| interface Album { |
Owner
There was a problem hiding this comment.
Can you move this interface into a new folder under music called 'consts' please. :)
ageddesi
reviewed
Oct 2, 2022
| }) | ||
|
|
||
| app.get("/album/", (req: Request, res: Response) => { | ||
| let data: Album[] = [] |
Owner
There was a problem hiding this comment.
Are you able to add a qty in the url to help define the amount of songs that are returned in the playlist. :)
Owner
|
HI @jkol7, thank you for the PR. |
…include quantity of songs. Added Album to swagger and also fixed music text in swagger as it was about football.
Owner
|
@jkol7 So to confirm can you close this one if no longer needed. Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added album route for issue.