Skip to content

Exclude internal packages from changeset versioning and remove @agent-facets/engine from changesets#329

Merged
eXamadeus merged 1 commit into
mainfrom
julian/06-12-exclude_private_packages_from_changesets_and_reassign_engine_changes_to_agent-facets_
Jun 12, 2026
Merged

Exclude internal packages from changeset versioning and remove @agent-facets/engine from changesets#329
eXamadeus merged 1 commit into
mainfrom
julian/06-12-exclude_private_packages_from_changesets_and_reassign_engine_changes_to_agent-facets_

Conversation

@eXamadeus

Copy link
Copy Markdown
Member

Why

Internal packages (@agent-facets/engine, @agent-facets/common, @agent-facets/landing, @agent-facets/functions) should not be published to npm, so they need to be excluded from changesets versioning. Additionally, two existing changesets were incorrectly attributed to @agent-facets/engine rather than the root agent-facets package.

Details

  • Added the internal packages to the ignore list in the changeset config so they are never versioned or published.
  • Moved the changeset entries for "Make OnLog accept a lazy builder thunk..." and "Sort lockfile facet keys alphabetically..." from @agent-facets/engine to agent-facets, correcting the package attribution.

Copilot AI review requested due to automatic review settings June 12, 2026 23:15
@changeset-bot

changeset-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: cfb0795

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
agent-facets Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Member Author

@eXamadeus eXamadeus merged commit 7538424 into main Jun 12, 2026
5 checks passed

Copy link
Copy Markdown
Member Author

Merge activity

@eXamadeus eXamadeus deleted the julian/06-12-exclude_private_packages_from_changesets_and_reassign_engine_changes_to_agent-facets_ branch June 12, 2026 23:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Changesets configuration and existing changeset entries so that internal (private) workspace packages are excluded from Changesets versioning/publishing, and two changesets previously attributed to @agent-facets/engine are correctly attributed to the root agent-facets package.

Changes:

  • Added @agent-facets/engine, @agent-facets/common, @agent-facets/landing, and @agent-facets/functions to .changeset/config.json’s ignore list.
  • Updated .changeset/quiet-sloths-jam.md to bump agent-facets instead of @agent-facets/engine.
  • Updated .changeset/floppy-maps-chew.md to remove the @agent-facets/engine bump entry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.changeset/config.json Configures Changesets to ignore internal/private packages so they are not versioned/published.
.changeset/quiet-sloths-jam.md Re-attributes the patch bump from @agent-facets/engine to agent-facets.
.changeset/floppy-maps-chew.md Removes the @agent-facets/engine entry so only agent-facets is bumped.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants