fix(agentsys-resolver): prefer plugin's own vendored lib/ (fixes CI)#33
Merged
Conversation
findAgentsysLib() only searched for an EXTERNAL agentsys install (CC marketplace, npm global, require.resolve, dev sibling). In bare CI none exist, so the 3 tests that actually resolve (findAgentsysLib + get()) threw 'agentsys/lib not found' and failed every PR's CI. But the sync still ships lib/binary/ (and the rest of the allowlist) into every plugin, so the resolver's OWN directory already satisfies the binary/index.js contract. Added __dirname as candidate 0: the plugin is now self-sufficient (works in CI, offline, no external install) and the external lookups remain as fallbacks for hosts that share a central agentsys. tests/agentsys-resolver.test.js: 7/7 pass (was 3 failing).
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
avifenesh
added a commit
that referenced
this pull request
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findAgentsysLib()only searched for an external agentsys install, so in bare CI it threw 'agentsys/lib not found' and failed every PR (the 3 resolving tests). Sync shipslib/binary/into every plugin - the resolver's own__dirnamealready satisfies thebinary/index.jscontract. Added__dirnameas candidate 0: self-sufficient in CI/offline, external lookups stay as fallback. 7/7 tests pass.