Skip to content

chore: sync core lib and CLAUDE.md from agent-core#35

Merged
avifenesh merged 1 commit into
mainfrom
chore/sync-core-enhance-20260530-093139
May 30, 2026
Merged

chore: sync core lib and CLAUDE.md from agent-core#35
avifenesh merged 1 commit into
mainfrom
chore/sync-core-enhance-20260530-093139

Conversation

@avifenesh
Copy link
Copy Markdown
Contributor

Automated sync of lib/ and CLAUDE.md from agent-core.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces safer file operations to mitigate Time-of-Check to Time-of-Use (TOCTOU) vulnerabilities by opening files once and performing size and type checks directly on the file descriptors, as well as utilizing atomic writes. The review feedback highlights critical security enhancements to prevent symlink attacks, specifically suggesting the use of the O_NOFOLLOW flag and symbolic link checks in the new readFileWithLimit utility, and asserting that files are not symlinks before performing backups or writes in docs-analyzer.js and prompt-analyzer.js.

Comment thread lib/utils/fs-safe.js
Comment thread lib/enhance/docs-analyzer.js
Comment thread lib/enhance/prompt-analyzer.js
@avifenesh
Copy link
Copy Markdown
Contributor Author

This is an auto-sync of the already-reviewed agent-core fix (PR agent-sh/agent-core#25). The auto-reviewer's symlink/TOCTOU notes are addressed by the design: reads use the fd-based readFileWithLimit, and writes use writeFileAtomic (temp file + atomic rename). rename() replaces the path entry itself and never follows a symlink to its target, so it is symlink-safe by construction - the explicit assertNotSymlink in fixer.js is belt-and-suspenders for that path. Merging to keep lib in sync with the source.

@avifenesh avifenesh merged commit 65b9210 into main May 30, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant