Fix KeyError when loading first skill in skills_tool#1122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
KeyError: 'loaded_skills'when callingskills_toolload for the first time in a fresh session by handling a missing key safely.Description
self.agent.data.get(DATA_NAME_LOADED_SKILLS)instead of direct indexing and initialize the list when the key is absent so the skill can be recorded without error.Testing
python -m py_compile python/tools/skills_tool.pysuccessfully; attemptedpytest tests/test_skills_tool.pybut collection failed due to missing optional runtime dependencies in the test environment, so the pytest run did not complete.Codex Task