chore(cli): route daemon version-mismatch notice to stderr#191
Merged
Conversation
console.log in ensureDaemon leaked into stdout when --json or pipe consumers ran a command while the daemon was on a stale version. Routing this operational notice to stderr keeps stdout clean for parseable output.
Contributor
|
🎉 PR Validation ✅ PASSED Commit: Checks:
Ready to merge! ✨ 🔗 View workflow run |
vreshch
force-pushed
the
chore/stderr-daemon-version
branch
from
be8266a to
f6f25fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensureDaemonprinted the daemon-vs-CLI version-mismatch notice viaconsole.log(stdout), with no TTY guardconsole.errorso stdout stays parseableTest plan
agentage runs list --json | jqnot corrupted by the yellow banner during a daemon upgrade