chore(deps): engine 0.1.3/0.0.3 - assert secret refusal, read clamp#224
Merged
Conversation
Contributor
|
🎉 PR Validation ✅ PASSED Commit: Checks:
Ready to merge! ✨ 🔗 View workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the engine to
@agentage/memory-core@^0.1.3+@agentage/server-memory@^0.0.3and turns the twotest.skipgaps in the frozen MCP contract tier into live assertions for the new engine behaviors.Dep bump
@agentage/memory-core^0.1.2->^0.1.3,@agentage/server-memory^0.0.2->^0.0.3(targeted install; the lock diff touches only these two packages and their subtree, no unrelated churn).New engine behaviors now asserted
write/editrefuse an obvious credential (fake AWSAKIA...EXAMPLEkey, PEM private-key block, or a secret injected viastr_replace new_str) with the canonicalRefused: this appears to contain ...message, and the doc is never persisted. Ordinary prose that merely mentions "password" still writes (no false positive).[Truncated for display: ...]marker on both MCP channels (structuredContent.body+content[0].text), while the on-disk file keeps the full original bytes.Tests
e2e/mcp-contract.test.ts: the twotest.skipentries replaced with real tests through the daemon/mcptransport (reusing the file's existing helpers). Uses clearly fake secret values only.e2e/memory-offline.test.ts: the same two behaviors at the CLI verb level -memory writeof a secret exits non-zero with the canonical message;memory readof an oversized doc prints the clamped body + marker while the stored file stays whole.Verification
npm run buildclean;mcp-contract+memory-offlinerun 3x each, all green; full offline set (35 tests) green;npm run verifygreen (incl. thelocal-servertools/list + instructions contract test on 0.0.3).0.1.2/0.0.2fails exactly the 4 new tests and passes the rest; restored0.1.3/0.0.3cleanly.