Fix /enroll page clipping content past the viewport#28
Merged
andrew-jon-p7a merged 1 commit intomainfrom May 1, 2026
Merged
Conversation
The global theme pins `body { overflow: hidden; position: fixed }` (see
packages/web-shell/src/styles/theme.css:101) so the document itself
never scrolls — every route owns its own scroll container. Enroll's
`<main>` was using `min-h-screen` inside an `.app h-full` wrapper, which
let content grow past the viewport with no scrollable parent: the
"create new member" branch (with its permissions grid) was
unreachable below the fold.
Fix: swap `<main>`'s `min-h-screen` for `flex:1 min-height:0
overflow-y:auto` so it fills the flex-column wrapper and exposes a
scrollbar when content overflows. Applied the same pattern to the
non-admin "Approval requires admin" fallback for consistency. Added
an inline comment near the main element explaining the relationship
to the global body rule, since the pattern isn't obvious without it.
Signed-off-by: Andrew Jon Przybilla <andrew@przy.email>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The global theme pins
body { overflow: hidden; position: fixed }(seepackages/web-shell/src/styles/theme.css:101) so the document itself
never scrolls — every route owns its own scroll container. Enroll's
<main>was usingmin-h-screeninside an.app h-fullwrapper, whichlet content grow past the viewport with no scrollable parent: the
"create new member" branch (with its permissions grid) was
unreachable below the fold.
Fix: swap
<main>'smin-h-screenforflex:1 min-height:0 overflow-y:autoso it fills the flex-column wrapper and exposes ascrollbar when content overflows. Applied the same pattern to the
non-admin "Approval requires admin" fallback for consistency. Added
an inline comment near the main element explaining the relationship
to the global body rule, since the pattern isn't obvious without it.