Fix CLI browser auth flow#307
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentclash auth loginfrom the terminal/user perspective: existing-token preflight,--force, env-token handling, browser URL fallback, strict polling, and clear denied/expired/error exitsPOST /v1/cli-auth/device/deny, while keeping CLI auth under/v1/cli-auth/*and returning absolute verification URLstesting/codex-fix-cli-auth-flow.mdReview Checkpoint
testing/codex-fix-cli-auth-flow.mdTests
cd cli && go test ./...cd backend && go test ./internal/api ./internal/repositorycd web && npm testcd web && npm run buildNotes
npm run buildpasses with an existing unrelated warning for unusedScorecardDimensionineval-spec-builder.tsx.npm cireported existing audit findings: 2 moderate and 2 high.