Regression workflow: add failure promotion modal#338
Merged
Conversation
Checkpoint: adds regression API helpers, status-aware promotion plumbing, and suite creation deep links. Reviewed against testing/codex-issue-324-promote-failure-dialog.md sections Unit Tests and Functional Behavior.
Checkpoint: wires promote actions on failure rows and adds the promotion modal UI. Reviewed against testing/codex-issue-324-promote-failure-dialog.md sections Functional Behavior, Smoke Tests, and Manual / cURL Tests.
Checkpoint: removes an unused type alias so pnpm lint runs clean on this branch. Reviewed against testing/codex-issue-324-promote-failure-dialog.md Integration / Functional Tests.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Checkpoint: removes the durable test-contract artifact, adds dialog coverage for new/idempotent/error paths, and tightens failure-row/dialog UX semantics. Reviewed against the reviewer punch list and rerun with pnpm lint, pnpm exec tsc --noEmit, and pnpm test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm lintis clean on this branchValidation
pnpm lintpnpm exec tsc --noEmitpnpm testManual curl verification
./scripts/dev/seed-local-run-fixture.sh.GET /v1/workspaces/22222222-2222-2222-2222-222222222222/runs/12121212-1212-1212-1212-121212121212/failuresreturned a promotable failure for challenge66666666-6666-6666-6666-666666666666.POST /v1/workspaces/22222222-2222-2222-2222-222222222222/regression-suitesreturned201and created suite0b23d391-afff-432c-8ca2-ac541bee401b.POST /v1/workspaces/22222222-2222-2222-2222-222222222222/runs/12121212-1212-1212-1212-121212121212/failures/66666666-6666-6666-6666-666666666666/promotereturned201and created case49ca72c1-5f0c-4e06-adff-ec2061ca4e7c.200with the same case id49ca72c1-5f0c-4e06-adff-ec2061ca4e7c, confirming the idempotent repost path.GET /v1/workspaces/22222222-2222-2222-2222-222222222222/regression-suites/0b23d391-afff-432c-8ca2-ac541bee401b/casesshows the promoted case persisted in the target suite.Notes
regression_suite_ids[]/regression_case_ids[]is not onmainyet.POST /v1/runsstill deadlocked once on this machine during manual stack work (load runnable challenge pack version: ... deadlock detected), so the promotion curl verification used a direct local DB seed for the completed run/failure-review fixture while still exercising the real HTTP suite/failures/promote endpoints end-to-end.Closes #324