Skip to content

feat(skills): add P1 portable agent skills (harness, multi-turn, dataset, prompt-eval)#925

Merged
Atharva-Kanherkar merged 12 commits into
mainfrom
feat/skills-p1-workflow
Jun 2, 2026
Merged

feat(skills): add P1 portable agent skills (harness, multi-turn, dataset, prompt-eval)#925
Atharva-Kanherkar merged 12 commits into
mainfrom
feat/skills-p1-workflow

Conversation

@Atharva-Kanherkar
Copy link
Copy Markdown
Collaborator

Summary

  • Adds four P1 portable agent skills from Agent Skills architecture audit: wiring, distribution, and coverage gaps #922: agentclash-agent-harness-setup, agentclash-multi-turn-operator, agentclash-dataset-workflows, and agentclash-prompt-eval-playground.
  • Updates catalog dependency order, hub workflow map, docs navigation, and docs generator tests (23 skills total).
  • Cross-links eval-runner and CI release gate skills to the new workflows.

Test plan

  • cd web && npm test -- docs.test.ts
  • cd web && npm run lint
  • CI green on merge

Lock expectations for four P1 portable skills and docs generator updates.
Document harness create/run, suites, executions, and failure review CLI flows.
Cover human takeover via run turn status and submit for multi_turn packs.
Document dataset eval gates, generation, trace import, and regression sync.
Document prompt-eval YAML lifecycle and playground experiment commands.
Register harness, multi-turn, dataset, and prompt-eval in the reading order.
Add optional branches and table entries for the four new operating skills.
Expose harness, multi-turn, dataset, and prompt-eval pages in DOCS_NAV.
Assert markdown paths, nav resolution, and source-backed command strings.
Point multi_turn human takeover flows at the dedicated operator skill.
Cross-reference dataset test gates as an alternative CI gating surface.
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Jun 2, 2026

Greptile Summary

Adds four P1 portable agent skills (agentclash-agent-harness-setup, agentclash-multi-turn-operator, agentclash-dataset-workflows, agentclash-prompt-eval-playground) along with the necessary catalog ordering, hub workflow map, docs nav, and docs-generator test updates to bring the total to 23 skills.

  • Each new SKILL.md covers commands, failure modes, safety notes, and bidirectional Related Skills cross-links; the existing eval-runner and ci-release-gate skills are updated to reference the new peers.
  • docs.ts registers the four new nav entries and docs.test.ts adds one describe block per skill verifying slug resolution, page title, and key content — titles in the tests match what formatTitleFromSlug actually produces.

Confidence Score: 4/5

Safe to merge — the change is documentation and nav metadata with no runtime code paths or data mutations.

The nav title 'Multi-Turn Operator Skill' contains a hyphen that formatTitleFromSlug strips, making the sidebar link text differ from the page heading. The tests correctly assert the computed (hyphen-free) form so CI stays green, but the nav display and h1 diverge for this one skill.

web/src/lib/docs.ts — the Multi-Turn Operator nav title entry.

Important Files Changed

Filename Overview
web/src/lib/docs.ts Adds four new DocNavItem entries for the P1 skills; 'Multi-Turn Operator Skill' nav title includes a hyphen while the computed page title from formatTitleFromSlug strips hyphens, producing 'Multi Turn Operator Skill' — a visible sidebar vs page-heading inconsistency.
web/src/lib/docs.test.ts Registers four new skill slugs and adds one describe block per new skill; title assertions match the actual computed titles from getDocBySlug, so tests will pass.
web/content/agent-skills/agentclash-multi-turn-operator/SKILL.md New skill covering human takeover turns in multi_turn packs; commands, failure modes, and safety notes are internally consistent.
web/content/agent-skills/agentclash-agent-harness-setup/SKILL.md New skill for E2B coding-agent harness tasks and suites; procedure, commands, and related-skills cross-links look correct.
web/content/agent-skills/agentclash-dataset-workflows/SKILL.md New skill for dataset CRUD, eval, CI gating, trace import, and regression sync; commands and failure modes are internally consistent.
web/content/agent-skills/agentclash-prompt-eval-playground/SKILL.md New skill for prompt-eval YAML lifecycle and playground CRUD; commands, failure modes, and related-skills links are internally consistent.
web/content/agent-skills/agentclash-hub/SKILL.md Adds four new skills to both the numbered dependency order list (21–24) and the optional branches section; the workflow map table is updated consistently.
web/content/agent-skills/SKILL.md Catalog dependency order extended to 24 entries, matching the hub's numbered list; no conflicts found.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    HUB[agentclash-hub]

    subgraph Core["Core eval flow (1-20)"]
        EVAL[agentclash-eval-runner]
        CI[agentclash-ci-release-gate]
        RF[agentclash-regression-flywheel]
    end

    subgraph New["New P1 optional branches (21-24)"]
        MT[agentclash-multi-turn-operator]
        DS[agentclash-dataset-workflows]
        PE[agentclash-prompt-eval-playground]
        AH[agentclash-agent-harness-setup]
    end

    HUB --> Core
    HUB --> New

    EVAL -->|multi_turn human phase| MT
    CI -->|dataset eval gate| DS
    RF -->|suite sync| DS
    DS --> PE
    DS --> EVAL
    AH --> EVAL
Loading

Fix All in Codex

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
web/src/lib/docs.ts:487-493
The nav title `"Multi-Turn Operator Skill"` contains a hyphen, but `formatTitleFromSlug` splits on `-` and joins with spaces, so `agentclash-multi-turn-operator` always computes to `"Multi Turn Operator Skill"`. This leaves the sidebar link text and the actual page `<h1>` / JSON-LD title out of sync. All other new skill entries in this diff use the space-separated form that matches the computed title.

```suggestion
      {
        title: "Multi Turn Operator Skill",
        description:
          "Submit human operator messages when multi_turn run agents await input.",
        slug: ["agent-skills", "agentclash-multi-turn-operator"],
        href: "/docs/agent-skills/agentclash-multi-turn-operator",
      },
```

Reviews (1): Last reviewed commit: "docs(skills): link CI release gate to da..." | Re-trigger Greptile

Comment thread web/src/lib/docs.ts
Comment on lines +487 to +493
{
title: "Multi-Turn Operator Skill",
description:
"Submit human operator messages when multi_turn run agents await input.",
slug: ["agent-skills", "agentclash-multi-turn-operator"],
href: "/docs/agent-skills/agentclash-multi-turn-operator",
},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The nav title "Multi-Turn Operator Skill" contains a hyphen, but formatTitleFromSlug splits on - and joins with spaces, so agentclash-multi-turn-operator always computes to "Multi Turn Operator Skill". This leaves the sidebar link text and the actual page <h1> / JSON-LD title out of sync. All other new skill entries in this diff use the space-separated form that matches the computed title.

Suggested change
{
title: "Multi-Turn Operator Skill",
description:
"Submit human operator messages when multi_turn run agents await input.",
slug: ["agent-skills", "agentclash-multi-turn-operator"],
href: "/docs/agent-skills/agentclash-multi-turn-operator",
},
{
title: "Multi Turn Operator Skill",
description:
"Submit human operator messages when multi_turn run agents await input.",
slug: ["agent-skills", "agentclash-multi-turn-operator"],
href: "/docs/agent-skills/agentclash-multi-turn-operator",
},
Prompt To Fix With AI
This is a comment left during a code review.
Path: web/src/lib/docs.ts
Line: 487-493

Comment:
The nav title `"Multi-Turn Operator Skill"` contains a hyphen, but `formatTitleFromSlug` splits on `-` and joins with spaces, so `agentclash-multi-turn-operator` always computes to `"Multi Turn Operator Skill"`. This leaves the sidebar link text and the actual page `<h1>` / JSON-LD title out of sync. All other new skill entries in this diff use the space-separated form that matches the computed title.

```suggestion
      {
        title: "Multi Turn Operator Skill",
        description:
          "Submit human operator messages when multi_turn run agents await input.",
        slug: ["agent-skills", "agentclash-multi-turn-operator"],
        href: "/docs/agent-skills/agentclash-multi-turn-operator",
      },
```

How can I resolve this? If you propose a fix, please make it concise.

Fix in Codex

Greptile: sidebar title must match formatTitleFromSlug output (no hyphen).
@Atharva-Kanherkar Atharva-Kanherkar merged commit c0601a0 into main Jun 2, 2026
8 checks passed
@Atharva-Kanherkar Atharva-Kanherkar deleted the feat/skills-p1-workflow branch June 2, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant