feat: add command wrapper hook and upgrade to Conductor#5
Merged
nikomatsakis merged 2 commits intoJun 3, 2026
Merged
Conversation
Contributor
nikomatsakis
commented
Jun 3, 2026
nikomatsakis
commented
- Upgrade agent-client-protocol from 0.11 to 0.13
- Add agent-client-protocol-conductor dependency
- Replace manual stdin/stdout forwarding with ConductorImpl, which handles acp-over-mcp and future protocol extensions
- Add CommandWrapper trait and ResolvedCommand struct for sandboxing (e.g., bwrap) — callers can intercept the resolved program/args/envs before the process is spawned
- Make Acpr generic over the wrapper type (Acpr<W: CommandWrapper>) with NullWrapper as the zero-cost default
- Upgrade agent-client-protocol from 0.11 to 0.13 - Add agent-client-protocol-conductor dependency - Replace manual stdin/stdout forwarding with ConductorImpl, which handles acp-over-mcp and future protocol extensions - Add CommandWrapper trait and ResolvedCommand struct for sandboxing (e.g., bwrap) — callers can intercept the resolved program/args/envs before the process is spawned - Make Acpr generic over the wrapper type (Acpr<W: CommandWrapper>) with NullWrapper as the zero-cost default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.