Skip to content

Fix missing as_ref calls for trait impls #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benbrandt merged 1 commit into from
Sep 24, 2025
Merged

Fix missing as_ref calls for trait impls #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions rust/agent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,82 +147,82 @@ pub trait Agent {
#[async_trait::async_trait(?Send)]
impl<T: Agent> Agent for Rc<T> {
async fn initialize(&self, args: InitializeRequest) -> Result<InitializeResponse, Error> {
self.initialize(args).await
self.as_ref().initialize(args).await
}
async fn authenticate(&self, args: AuthenticateRequest) -> Result<AuthenticateResponse, Error> {
self.authenticate(args).await
self.as_ref().authenticate(args).await
}
async fn new_session(&self, args: NewSessionRequest) -> Result<NewSessionResponse, Error> {
self.new_session(args).await
self.as_ref().new_session(args).await
}
async fn load_session(&self, args: LoadSessionRequest) -> Result<LoadSessionResponse, Error> {
self.load_session(args).await
self.as_ref().load_session(args).await
}
async fn set_session_mode(
&self,
args: SetSessionModeRequest,
) -> Result<SetSessionModeResponse, Error> {
self.set_session_mode(args).await
self.as_ref().set_session_mode(args).await
}
async fn prompt(&self, args: PromptRequest) -> Result<PromptResponse, Error> {
self.prompt(args).await
self.as_ref().prompt(args).await
}
async fn cancel(&self, args: CancelNotification) -> Result<(), Error> {
self.cancel(args).await
self.as_ref().cancel(args).await
}
#[cfg(feature = "unstable")]
async fn set_session_model(
&self,
args: SetSessionModelRequest,
) -> Result<SetSessionModelResponse, Error> {
self.set_session_model(args).await
self.as_ref().set_session_model(args).await
}
async fn ext_method(&self, args: ExtRequest) -> Result<ExtResponse, Error> {
self.ext_method(args).await
self.as_ref().ext_method(args).await
}
async fn ext_notification(&self, args: ExtNotification) -> Result<(), Error> {
self.ext_notification(args).await
self.as_ref().ext_notification(args).await
}
}

#[async_trait::async_trait(?Send)]
impl<T: Agent> Agent for Arc<T> {
async fn initialize(&self, args: InitializeRequest) -> Result<InitializeResponse, Error> {
self.initialize(args).await
self.as_ref().initialize(args).await
}
async fn authenticate(&self, args: AuthenticateRequest) -> Result<AuthenticateResponse, Error> {
self.authenticate(args).await
self.as_ref().authenticate(args).await
}
async fn new_session(&self, args: NewSessionRequest) -> Result<NewSessionResponse, Error> {
self.new_session(args).await
self.as_ref().new_session(args).await
}
async fn load_session(&self, args: LoadSessionRequest) -> Result<LoadSessionResponse, Error> {
self.load_session(args).await
self.as_ref().load_session(args).await
}
async fn set_session_mode(
&self,
args: SetSessionModeRequest,
) -> Result<SetSessionModeResponse, Error> {
self.set_session_mode(args).await
self.as_ref().set_session_mode(args).await
}
async fn prompt(&self, args: PromptRequest) -> Result<PromptResponse, Error> {
self.prompt(args).await
self.as_ref().prompt(args).await
}
async fn cancel(&self, args: CancelNotification) -> Result<(), Error> {
self.cancel(args).await
self.as_ref().cancel(args).await
}
#[cfg(feature = "unstable")]
async fn set_session_model(
&self,
args: SetSessionModelRequest,
) -> Result<SetSessionModelResponse, Error> {
self.set_session_model(args).await
self.as_ref().set_session_model(args).await
}
async fn ext_method(&self, args: ExtRequest) -> Result<ExtResponse, Error> {
self.ext_method(args).await
self.as_ref().ext_method(args).await
}
async fn ext_notification(&self, args: ExtNotification) -> Result<(), Error> {
self.ext_notification(args).await
self.as_ref().ext_notification(args).await
}
}

Expand Down
44 changes: 22 additions & 22 deletions rust/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,58 +169,58 @@ impl<T: Client> Client for Rc<T> {
&self,
args: RequestPermissionRequest,
) -> Result<RequestPermissionResponse, Error> {
self.request_permission(args).await
self.as_ref().request_permission(args).await
}
async fn write_text_file(
&self,
args: WriteTextFileRequest,
) -> Result<WriteTextFileResponse, Error> {
self.write_text_file(args).await
self.as_ref().write_text_file(args).await
}
async fn read_text_file(
&self,
args: ReadTextFileRequest,
) -> Result<ReadTextFileResponse, Error> {
self.read_text_file(args).await
self.as_ref().read_text_file(args).await
}
async fn session_notification(&self, args: SessionNotification) -> Result<(), Error> {
self.session_notification(args).await
self.as_ref().session_notification(args).await
}
async fn create_terminal(
&self,
args: CreateTerminalRequest,
) -> Result<CreateTerminalResponse, Error> {
self.create_terminal(args).await
self.as_ref().create_terminal(args).await
}
async fn terminal_output(
&self,
args: TerminalOutputRequest,
) -> Result<TerminalOutputResponse, Error> {
self.terminal_output(args).await
self.as_ref().terminal_output(args).await
}
async fn release_terminal(
&self,
args: ReleaseTerminalRequest,
) -> Result<ReleaseTerminalResponse, Error> {
self.release_terminal(args).await
self.as_ref().release_terminal(args).await
}
async fn wait_for_terminal_exit(
&self,
args: WaitForTerminalExitRequest,
) -> Result<WaitForTerminalExitResponse, Error> {
self.wait_for_terminal_exit(args).await
self.as_ref().wait_for_terminal_exit(args).await
}
async fn kill_terminal_command(
&self,
args: KillTerminalCommandRequest,
) -> Result<KillTerminalCommandResponse, Error> {
self.kill_terminal_command(args).await
self.as_ref().kill_terminal_command(args).await
}
async fn ext_method(&self, args: ExtRequest) -> Result<ExtResponse, Error> {
self.ext_method(args).await
self.as_ref().ext_method(args).await
}
async fn ext_notification(&self, args: ExtNotification) -> Result<(), Error> {
self.ext_notification(args).await
self.as_ref().ext_notification(args).await
}
}

Expand All @@ -230,58 +230,58 @@ impl<T: Client> Client for Arc<T> {
&self,
args: RequestPermissionRequest,
) -> Result<RequestPermissionResponse, Error> {
self.request_permission(args).await
self.as_ref().request_permission(args).await
}
async fn write_text_file(
&self,
args: WriteTextFileRequest,
) -> Result<WriteTextFileResponse, Error> {
self.write_text_file(args).await
self.as_ref().write_text_file(args).await
}
async fn read_text_file(
&self,
args: ReadTextFileRequest,
) -> Result<ReadTextFileResponse, Error> {
self.read_text_file(args).await
self.as_ref().read_text_file(args).await
}
async fn session_notification(&self, args: SessionNotification) -> Result<(), Error> {
self.session_notification(args).await
self.as_ref().session_notification(args).await
}
async fn create_terminal(
&self,
args: CreateTerminalRequest,
) -> Result<CreateTerminalResponse, Error> {
self.create_terminal(args).await
self.as_ref().create_terminal(args).await
}
async fn terminal_output(
&self,
args: TerminalOutputRequest,
) -> Result<TerminalOutputResponse, Error> {
self.terminal_output(args).await
self.as_ref().terminal_output(args).await
}
async fn release_terminal(
&self,
args: ReleaseTerminalRequest,
) -> Result<ReleaseTerminalResponse, Error> {
self.release_terminal(args).await
self.as_ref().release_terminal(args).await
}
async fn wait_for_terminal_exit(
&self,
args: WaitForTerminalExitRequest,
) -> Result<WaitForTerminalExitResponse, Error> {
self.wait_for_terminal_exit(args).await
self.as_ref().wait_for_terminal_exit(args).await
}
async fn kill_terminal_command(
&self,
args: KillTerminalCommandRequest,
) -> Result<KillTerminalCommandResponse, Error> {
self.kill_terminal_command(args).await
self.as_ref().kill_terminal_command(args).await
}
async fn ext_method(&self, args: ExtRequest) -> Result<ExtResponse, Error> {
self.ext_method(args).await
self.as_ref().ext_method(args).await
}
async fn ext_notification(&self, args: ExtNotification) -> Result<(), Error> {
self.ext_notification(args).await
self.as_ref().ext_notification(args).await
}
}

Expand Down