Feat: Add session/list API for managing and discovering sessions#226
Conversation
codefromthecrypt
left a comment
codefromthecrypt
left a comment
There was a problem hiding this comment.
forgive me if there are standards in general we are using which indicate serialize null on a non-required field. this is a bikeshed, just trying to understand if we are intentional on this or if it was just a practice and not too late to discuss it.
This commit introduces the `session/list` capability, allowing agents to list existing sessions with optional filtering and pagination. It includes the `ListSessionsRequest` and `ListSessionsResponse` structures, along with the necessary updates to the protocol documentation and JSON schema. This feature is marked as **UNSTABLE** and may change in future iterations.
benbrandt
force-pushed
the
feat/list-sessions
branch
from
8bc0bc1 to
b52fe00
Compare
- Remove limit parameter from ListSessionsRequest - Make createdAt and updatedAt optional in SessionInfo - Update RFD documentation to reflect changes - Regenerate schema files
|
Hey! Sorry for jumping in here. I was about to propose a feature like I think such an addition naturally fits into that PR. |
|
Hey @ignatov — I like the idea. I just don’t think it belongs in this PR. Something like
Either way, that’s a broader protocol/API change and should go through a separate RFD. |
|
Hi yes I agree:
Mainly because I want these changes to be reviewable, and while this notification is connected, I think it can build on top of it. One thing we may want to decide if people have strong opinions is if we should call this field "title" or "name" if we have strong opinions there, so that we can have one concept. But I know there are some teams that definitely have opinions on titles and how they should be updated (should the client be able to rename it for example) so I think there will be enough to discuss in its own RFD for sure. |
|
Okay, in that case SessionInfo should be aligned with the current session primitive. I think it should use the same structure that describes the current session and we use in |
|
@ignatov I'm confused now... this is the PR that introduces |
|
@ignatov I am going to go ahead and merge as-is. This RFD is still in draft stage, not preview yet, so we can still continue the discussion if you feel there is something missing here |
benbrandt
left a comment
benbrandt
left a comment
There was a problem hiding this comment.
Looks ready to start testing out to me!
@benbrandt, sure |
|
please tag the session name update PR or issue back here, as it is really important agreed! |
4 participants
This commit introduces the
session/listcapability, allowing agents to list existing sessions with optional filtering and pagination. It includes theListSessionsRequestandListSessionsResponsestructures, along with the necessary updates to the protocol documentation and JSON schema. This feature is marked as UNSTABLE and may change in future iterations.