jsonrpc: Specify mandatory jsonrpc Version Property#52
Merged
agu-z merged 2 commits intoagentclientprotocol:mainfrom Sep 2, 2025
Merged
jsonrpc: Specify mandatory jsonrpc Version Property#52agu-z merged 2 commits intoagentclientprotocol:mainfrom
jsonrpc Version Property#52agu-z merged 2 commits intoagentclientprotocol:mainfrom
Conversation
Contributor
Author
I thought this way would be better. However, if you insist, I'll add wrapping to Another way would be making it optional for deserialization, which I'm in favor with. |
Contributor
|
Looks good! Thank you for your contribution @tyranron ❤️ |
nerzhulart
pushed a commit
to nerzhulart/agent-client-protocol
that referenced
this pull request
Oct 21, 2025
…tocol#52) * Wrap outgoing `rpc::OutgoingMessage` into `rpc::JsonRpcMessage` * Wrap when sending errors too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes zed-industries/zed#37128
Synopsis
ACP protocol uses 2.0 version of JSON-RPC protocol, and JSON-RPC 2.0 Specification requires
"jsonrpc": "2.0"field to be always present.Solution
Provide
rpc::JsonRpcMessageas a wrapper forrpc::OutgoingMessagewhen sending them.rpc::IncomingMessageare not wrapped on receiving for better compatibility with other parties, which may miss this field.Changelog
Release Notes:
"jsonrpc": "2.0"field