Open
Conversation
| } | ||
| } | ||
|
|
||
| async flushServerNotifications(sessionId: string): Promise<void> { |
Collaborator
There was a problem hiding this comment.
I'm not sure why do we need a queue and then why we need to flush it instead of handling events?
Collaborator
Author
There was a problem hiding this comment.
Because sendPrompt() must not return until all earlier events have been handled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
This makes edit tool calls understandable in the UI and avoids races where a completion update can arrive before the corresponding tool call exists.
Testing
npm test