fix: Remove redundant Box::pin calls from async code#106
Merged
Conversation
Yesterday, Clippy complained a lot about large futures. I couldn't figure out what the root cause was and just added them everywhere clippy complained. However, when adding to Zed I was getting stack overflows and was able to trace it to the Builder::into_connection_and_future where the futures with the connection were actually the root cause. Adding Box::pin there means we can remove them from all of the tests/examples/etc, which makes things look nice and beautiful again!
benbrandt
changed the title
benbrandt
commented
Apr 2, 2026
| }; | ||
|
|
||
| crate::util::run_until(background, main_fn(connection.clone())).await | ||
| crate::util::run_until(Box::pin(background), Box::pin(main_fn(connection.clone()))) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yesterday, Clippy complained a lot about large futures. I couldn't
figure out what the root cause was and just added them everywhere clippy
complained.
However, when adding to Zed I was getting stack overflows and was able
to trace it to the Builder::into_connection_and_future where the futures
with the connection were actually the root cause.
Adding Box::pin there means we can remove them from all of the
tests/examples/etc, which makes things look nice and beautiful again!