Skip to content

add conditional compilation#98

Merged
benbrandt merged 1 commit intoagentclientprotocol:mainfrom
anaslimem:fix-test-stable
Mar 31, 2026
Merged

add conditional compilation#98
benbrandt merged 1 commit intoagentclientprotocol:mainfrom
anaslimem:fix-test-stable

Conversation

@anaslimem
Copy link
Copy Markdown
Contributor

@anaslimem anaslimem commented Mar 31, 2026 •
edited
Loading

Add conditional compilation for set_session_config_option to handle both
SessionConfigOptionValue and SessionConfigValueId types depending on the
unstable_boolean_config feature flag.

Without the unstable_boolean_config feature, args.value is of type
SessionConfigValueId which does not have an as_value_id() method, causing
compilation failures. This fix ensures the code compiles and works correctly
in both stable mode (13 tests) and unstable mode (16 tests).

@benbrandt benbrandt enabled auto-merge (squash) March 31, 2026 15:35
@benbrandt benbrandt merged commit 4f3f2c4 into agentclientprotocol:main Mar 31, 2026
1 check passed
@anaslimem
Copy link
Copy Markdown
Contributor Author

anaslimem commented Mar 31, 2026

fixes #91

@acp-release-bot acp-release-bot bot mentioned this pull request Mar 31, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benbrandt benbrandt benbrandt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anaslimem @benbrandt