Skip to content

refactor: Mark experimental session methods as unstable #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benbrandt merged 1 commit into from
Dec 12, 2025
Merged

refactor: Mark experimental session methods as unstable #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions src/acp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,18 +65,18 @@ export class AgentSideConnection {
return agent.loadSession(validatedParams);
}
case schema.AGENT_METHODS.session_fork: {
if (!agent.forkSession) {
if (!agent.unstable_forkSession) {
throw RequestError.methodNotFound(method);
}
const validatedParams = validate.zForkSessionRequest.parse(params);
return agent.forkSession(validatedParams);
return agent.unstable_forkSession(validatedParams);
}
case schema.AGENT_METHODS.session_resume: {
if (!agent.resumeSession) {
if (!agent.unstable_resumeSession) {
throw RequestError.methodNotFound(method);
}
const validatedParams = validate.zResumeSessionRequest.parse(params);
return agent.resumeSession(validatedParams);
return agent.unstable_resumeSession(validatedParams);
}
case schema.AGENT_METHODS.session_set_mode: {
if (!agent.setSessionMode) {
Expand All @@ -96,12 +96,12 @@ export class AgentSideConnection {
return agent.prompt(validatedParams);
}
case schema.AGENT_METHODS.session_set_model: {
if (!agent.setSessionModel) {
if (!agent.unstable_setSessionModel) {
throw RequestError.methodNotFound(method);
}
const validatedParams =
validate.zSetSessionModelRequest.parse(params);
const result = await agent.setSessionModel(validatedParams);
const result = await agent.unstable_setSessionModel(validatedParams);
return result ?? {};
}
default:
Expand Down Expand Up @@ -628,8 +628,10 @@ export class ClientSideConnection implements Agent {
* operations like generating summaries without affecting the original session's history.
*
* This method is only available if the agent advertises the `session.fork` capability.
*
* @experimental
*/
async forkSession(
async unstable_forkSession(
params: schema.ForkSessionRequest,
): Promise<schema.ForkSessionResponse> {
return await this.#connection.sendRequest(
Expand All @@ -649,8 +651,10 @@ export class ClientSideConnection implements Agent {
*
* The agent should resume the session context, allowing the conversation to continue
* without replaying the message history (unlike `session/load`).
*
* @experimental
*/
async resumeSession(
async unstable_resumeSession(
params: schema.ResumeSessionRequest,
): Promise<schema.ResumeSessionResponse> {
return await this.#connection.sendRequest(
Expand Down Expand Up @@ -694,7 +698,7 @@ export class ClientSideConnection implements Agent {
*
* @experimental
*/
async setSessionModel(
async unstable_setSessionModel(
params: schema.SetSessionModelRequest,
): Promise<schema.SetSessionModelResponse> {
return (
Expand Down Expand Up @@ -1440,8 +1444,10 @@ export interface Agent {
* operations like generating summaries without affecting the original session's history.
*
* This method is only available if the agent advertises the `session.fork` capability.
*
* @experimental
*/
forkSession?(
unstable_forkSession?(
params: schema.ForkSessionRequest,
): Promise<schema.ForkSessionResponse>;
/**
Expand All @@ -1455,8 +1461,10 @@ export interface Agent {
*
* The agent should resume the session context, allowing the conversation to continue
* without replaying the message history (unlike `session/load`).
*
* @experimental
*/
resumeSession?(
unstable_resumeSession?(
params: schema.ResumeSessionRequest,
): Promise<schema.ResumeSessionResponse>;
/**
Expand Down Expand Up @@ -1486,7 +1494,7 @@ export interface Agent {
*
* @experimental
*/
setSessionModel?(
unstable_setSessionModel?(
params: schema.SetSessionModelRequest,
): Promise<schema.SetSessionModelResponse | void>;
/**
Expand Down