Skip to content

feat(ui): add full control JSON editing and create-from-JSON#147

Merged
lan17 merged 1 commit intomainfrom
feature/control-json-editor-hint
Mar 26, 2026
Merged

feat(ui): add full control JSON editing and create-from-JSON#147
lan17 merged 1 commit intomainfrom
feature/control-json-editor-hint

Conversation

@lan17
Copy link
Copy Markdown
Contributor

@lan17 lan17 commented Mar 25, 2026

Summary

  • add Full JSON mode for editing the entire control definition from the control modal
  • add From JSON in the create-control flow so a control can be created directly from JSON without picking an evaluator first
  • reuse a shared JSON editor for both full control definitions and evaluator config JSON
  • add helper text clarifying that the control JSON editor expects the raw control definition, not data / name / id wrapper objects
  • add Playwright coverage for the JSON create/edit flows

Testing

  • make ui-typecheck
  • make ui-lint (passes; existing no-img-element warnings remain in ui/src/core/layouts/app-layout.tsx)

Screenshots

New control UI now has From JSON button`
image

When you click on it you get this
Screenshot 2026-03-24 at 9 11 12 PM

you can also edit full json in control now
Screenshot 2026-03-24 at 9 11 38 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@lan17 lan17 force-pushed the feature/control-json-editor-hint branch from fe8ddd4 to 5fa2b9f Compare March 25, 2026 02:36
@lan17 lan17 changed the title fix(ui): clarify control JSON editor input shape fix(ui): complete control JSON editor rollout Mar 25, 2026
@lan17 lan17 force-pushed the feature/control-json-editor-hint branch from 5fa2b9f to 7896863 Compare March 25, 2026 04:08
@lan17 lan17 changed the title fix(ui): complete control JSON editor rollout feat(ui): restore full control JSON editing and create-from-JSON Mar 25, 2026
@lan17 lan17 changed the title feat(ui): restore full control JSON editing and create-from-JSON feat(ui): add full control JSON editing and create-from-JSON Mar 25, 2026
@lan17 lan17 requested review from namrataghadi-galileo and siddhant-galileo and removed request for siddhant-galileo March 25, 2026 04:12
@lan17 lan17 enabled auto-merge (squash) March 25, 2026 23:57
@lan17 lan17 disabled auto-merge March 26, 2026 00:12
@lan17 lan17 merged commit e685ed0 into main Mar 26, 2026
10 checks passed
@lan17 lan17 deleted the feature/control-json-editor-hint branch March 26, 2026 00:12
galileo-automation pushed a commit that referenced this pull request Apr 7, 2026
## [2.2.0](ts-sdk-v2.1.0...ts-sdk-v2.2.0) (2026-04-07)

### Features

* **evaluators:** add starts_with/ends_with mode to list evaluator ([#154](#154)) ([bf1f7d7](bf1f7d7))
* **sdk:** [Enterprise Integration]: Add provider agnostic traceing ([#145](#145)) ([f1ca27c](f1ca27c))
* **sdk:** Add telemetry package to support sinks ([#164](#164)) ([2186ba1](2186ba1))
* **sdk:** default merge events in SDK ([#155](#155)) ([5984a60](5984a60))
* **server,sdk, ui:** Control Templates ([#158](#158)) ([78bb538](78bb538))
* **server:** Override PG password in dockerfile ([#148](#148)) ([5d70c7d](5d70c7d))
* **server:** Remove container name for dev postgres ([92b2d13](92b2d13))
* **server:** Start local dev pg under docker compose project endign with dev ([88bee63](88bee63))
* **ui, server:** Intuitive JSON editing for Controls ([#151](#151)) ([8c23cef](8c23cef))
* **ui:** add full control JSON editing and create-from-JSON ([#147](#147)) ([e685ed0](e685ed0))

### Bug Fixes

* **docs:** add explicit shutdown to quickstart example ([#149](#149)) ([b76014f](b76014f))
* **sdk:** use sync shutdown flush fallback ([#150](#150)) ([90265ba](90265ba))
* **server:**  remove unused evaluator config store ([#152](#152)) ([dea2873](dea2873))
* **server:** Omit null fields in control JSON editor ([#157](#157)) ([0aa2f3c](0aa2f3c))
* **server:** Update docker-compose.dev.yml to use different container name ([14d4c87](14d4c87))
* **ui:** improve edit control ux, no layout shift, consistent spacing ([#122](#122)) ([76d67b9](76d67b9))
@galileo-automation
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants