feat(sdk): Add telemetry package to support sinks#164
feat(sdk): Add telemetry package to support sinks#164namrataghadi-galileo wants to merge 4 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
lan17
left a comment
There was a problem hiding this comment.
telemetry/ is now a standalone workspace package, but it is not wired into the repo's standard validation path. Please add it to the normal make lint, make typecheck, and make test/CI coverage so it can't drift outside the usual gates.
I also think it should have its own direct tests, even if they stay lightweight. Right now the package only gets incidental coverage through SDK/server tests, but the package itself owns behavior like trace-context validation and the sync/async sink contract. Those are simple enough to unit test directly in telemetry/, and package-local tests will make refactors safer than relying only on downstream coverage.
Build & CI IntegrationRoot validation now includes CI/code coverage now picks up
Tests & Validation
|
lan17
left a comment
There was a problem hiding this comment.
The telemetry coverage gap is addressed. telemetry/ now has direct tests plus Makefile and CI wiring for test/lint/typecheck, which was the missing piece I called out earlier.
Summary
Added a new shared top-level
telemetry/package to hold common telemetry contracts and trace-context primitives used across AgentControl.Refactored the SDK observability write path to use the shared
ControlEventSinkcontract internally while preserving the existing default OSS behavior: queue-backed batching and delivery to/api/v1/observability/events.Aligned telemetry packaging with the existing models/engine bundling pattern so telemetry is vendored into SDK and server builds rather than treated as a separate runtime-only dependency.
Scope
User-facing / API changes
Internal changes
ControlEventSink,SinkResult,BaseControlEventSink, and shared trace-context helpers.Out of scope
/observability/eventsserver ingestion behavior.Risk and Rollout
Risk level: Medium
Rollback plan:
Testing
make check(or explained why not)Checklist