Skip to content

fix(sdk): fail closed on post-hook evaluation errors#114

Merged
lan17 merged 2 commits intomainfrom
codex/fix-112-post-hook-fail-closed
Mar 12, 2026
Merged

fix(sdk): fail closed on post-hook evaluation errors#114
lan17 merged 2 commits intomainfrom
codex/fix-112-post-hook-fail-closed

Conversation

@lan17
Copy link
Contributor

@lan17 lan17 commented Mar 11, 2026

Summary

  • make unexpected post-hook control evaluation failures fail closed instead of only logging
  • route pre/post hook evaluation through a shared helper so the enforcement policy stays consistent
  • add a regression test covering post-hook RuntimeError behavior

Testing

  • make sdk-typecheck
  • make sdk-test

Closes #112

@lan17 lan17 changed the title fix: fail closed on post-hook evaluation errors fix(sdk): fail closed on post-hook evaluation errors Mar 12, 2026
@lan17 lan17 enabled auto-merge (squash) March 12, 2026 00:09
Copy link
Contributor

@namrataghadi-galileo namrataghadi-galileo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LEts start with fail-closed. If the response is to have it fail open, we can change it later.

@lan17 lan17 disabled auto-merge March 12, 2026 00:17
@lan17 lan17 merged commit 67f8fc1 into main Mar 12, 2026
5 of 6 checks passed
@lan17 lan17 deleted the codex/fix-112-post-hook-fail-closed branch March 12, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants