fix(ui): Step name not getting saved#68
Merged
siddhant-galileo merged 12 commits intomainfrom Mar 10, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
abhinav-galileo
requested changes
Mar 6, 2026
Collaborator
abhinav-galileo
left a comment
abhinav-galileo
left a comment
There was a problem hiding this comment.
Low: Since this fixes a serialization round-trip bug, it would be good to have an automated test that saves a control with step_names in the scope and asserts they're present on reload. That's the exact scenario that broke and would catch regressions.
ui/src/core/page-components/agent-detail/modals/edit-control/step-name-input.tsx
Outdated
Show resolved
Hide resolved
abhinav-galileo
requested changes
Mar 9, 2026
Collaborator
abhinav-galileo
left a comment
abhinav-galileo
left a comment
There was a problem hiding this comment.
ui-ci is failing on Prettier in step-name-input.tsx. Fix formatting before merge.
abhinav-galileo
approved these changes
Mar 10, 2026
Collaborator
abhinav-galileo
left a comment
abhinav-galileo
left a comment
There was a problem hiding this comment.
Assuming we are able to reproduce the original bug on main and verify it's fixed on this branch...
galileo-automation
pushed a commit
that referenced
this pull request
Mar 11, 2026
## [1.1.0](ts-sdk-v1.0.1...ts-sdk-v1.1.0) (2026-03-11) ### Features * **examples:** add Google ADK Agent Control examples ([#69](#69)) ([4b83542](4b83542)) * **infra:** publish UI image and add compose UI service ([#57](#57)) ([207c1af](207c1af)) * **sdk:** 57143 strands extra ([#59](#59)) ([97f2518](97f2518)) * **sdk:** add shutdown() and ashutdown() lifecycle API ([#70](#70)) ([9e29d86](9e29d86)) * **sdk:** migrate strands integration to be a plugin ([#74](#74)) ([897ece3](897ece3)) * **server:** enforce admin-only control-plane mutations ([#62](#62)) ([579407f](579407f)), closes [#61](#61) * **ui:** serve exported Agent Control UI from the FastAPI server ([#71](#71)) ([c140198](c140198)) ### Bug Fixes * **docs:** add centered logo, header, and badges to README ([#92](#92)) ([39c3cbf](39c3cbf)) * **docs:** Test all examples ([#16](#16)) ([39e95c2](39e95c2)) * **evaluators:** migrate sqlglot rs extra to sqlglot c ([#86](#86)) ([5e3e48c](5e3e48c)) * **infra:** fix docker compose to make ui work ([#82](#82)) ([5edbb6b](5edbb6b)) * **infra:** Remove UI service from docker-compose.yml ([#91](#91)) ([330ef55](330ef55)) * **sdk): Revert "fix(sdk:** bundle evaluators in sdk wheel" ([#90](#90)) ([b516ea6](b516ea6)), closes [#89](#89) * **sdk:** bundle evaluators in sdk wheel ([#89](#89)) ([ea5889a](ea5889a)) * **sdk:** fix observability events not reaching the server ([#63](#63)) ([70016db](70016db)) * **ui:** name update being saved now ([#87](#87)) ([919672d](919672d)) * **ui:** Step name not getting saved ([#68](#68)) ([13abef9](13abef9))
Collaborator
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step name was not getting saved before. Working fine now.
Shortcut ticket - https://app.shortcut.com/galileo/story/57370/fix-step-names-in-the-ui
Scope
Risk and Rollout
Testing
make check(or explained why not)Checklist