fix(ui): create flow - name trimming issue#93
Conversation
… add slug name constraints to patch name reqiest too
lan17
left a comment
There was a problem hiding this comment.
Added two inline review comments.
ui/src/core/page-components/agent-detail/modals/edit-control/edit-control-content.tsx
Outdated
Show resolved
Hide resolved
|
I think the main unresolved issue here is the contract boundary. This repo already has a clear pattern for agent names: normalization is defined once and applied consistently across shared models, server endpoints, and SDK entry points. Control names still do not have that. In this PR, the only canonicalization being added is inside one UI flow, while the server create/patch endpoints and both SDKs still treat That matters because non-UI clients are real clients here. A browser user now gets trimming/canonicalization in the modal, but Python and TypeScript SDK callers still need to know to pre-trim or they will just hit API validation. I think we should make that choice explicit: either control-name canonicalization belongs at the server/shared boundary, or this remains validation-only and every client is responsible for sending canonical names. I would avoid implicitly defining canonical control names in one modal. Separately, the legacy-name policy should be explicit and covered by a regression test. The code reads like “existing invalid names remain editable unless the user actually renames them”, which seems reasonable, but it should be stated and tested directly. The login logo swap also looks unrelated to the trimming fix. If it’s intentional, I’d explain it in the PR; otherwise I’d split it out. |
Fixed this - moved logic to server now. UI only uses trim to check if name has updated or not
Added a line in PR description |
Summary
What changed and why.
Fix - https://galileoteamworkspace.slack.com/archives/C09TKBCRABG/p1773172188238399?thread_ts=1773165596.478009&cid=C09TKBCRABG
Also login modal icon fixed
Fixed logo color on login modal.
Scope
Risk and Rollout
Testing
make check(or explained why not)Checklist