fix(core): update build config

Author: AgentEnder

package-lock.json

@@ -5,6 +5,42 @@ hide_title: true
 sidebar_position: 2
 slug: /changelog
 ---
+## 1.2.0 (2025-08-22)
+
+### 🚀 Features
+
+- bump nx version ([bdd397b](https://github.com/agentender/nx-github-pages/commit/bdd397b))
+
+### ❤️ Thank You
+
+- Craigory Coppola @AgentEnder
+
+## 1.1.1 (2025-08-22)
+
+
+### 🩹 Fixes
+
+- **nx-github-pages:** correct build config s.t. executors work ([7ed482c](https://github.com/agentender/nx-github-pages/commit/7ed482c))
+
+### ❤️  Thank You
+
+- Craigory Coppola @AgentEnder
+
+## 1.1.0 (2025-08-22)
+
+
+### 🚀 Features
+
+- **nx-github-pages:** allow setting git user info in executor options ([a5de2f9](https://github.com/agentender/nx-github-pages/commit/a5de2f9))
+
+### 🩹 Fixes
+
+- **nx-github-pages:** fixup provenance setup ([13c7014](https://github.com/agentender/nx-github-pages/commit/13c7014))
+
+### ❤️  Thank You
+
+- Craigory Coppola @AgentEnder
+
 ## 1.0.1 (2025-08-22)
 
 

packages/docs-site/docs/changelog.md

@@ -4,7 +4,9 @@ import { existsSync, mkdirSync, readFileSync, rmSync, writeFileSync } from 'fs';
 import { ProjectConfiguration, workspaceRoot } from '@nx/devkit';
 
 describe('nx-github-pages', () => {
-  let projectDirectory, remote, remoteDirectory: string;
+  let projectDirectory: string;
+  let remote: string;
+  let remoteDirectory: string;
 
   // The state of the remote matters for some tests so we
   // are going to reinit everything everytime. This is not the most
@@ -26,15 +28,21 @@ describe('nx-github-pages', () => {
   });
 
   it('should deploy to gh-pages branch of remote', () => {
-    generateReactApp(projectDirectory, 'my-app');
+    const appName = 'my-app';
+    const nxProjectName = getNxProjectName(projectDirectory, appName);
+    generateReactApp(projectDirectory, appName);
 
     runCommand(
-      'npx nx g nx-github-pages:configuration --project my-app --user.name deployment-bot --user.email deployment@testing.com --no-interactive',
+      `npx nx g nx-github-pages:configuration --project ${nxProjectName} --user.name deployment-bot --user.email deployment@testing.com --no-interactive`,
       projectDirectory,
       {}
     );
 
-    runCommand('npx nx deploy my-app --no-interactive', projectDirectory, {});
+    runCommand(
+      `npx nx deploy ${nxProjectName} --no-interactive`,
+      projectDirectory,
+      {}
+    );
 
     // Check that the gh-pages branch exists in the remote
     runCommand('git checkout gh-pages', remoteDirectory, {});
@@ -46,32 +54,66 @@ describe('nx-github-pages', () => {
   });
 
   it('should sync via merge sync enabled and deployment already exists', () => {
+    const appName = 'my-app';
+    const nxProjectName = getNxProjectName(projectDirectory, appName);
+
     // SETUP
     // Create a new app
-    generateReactApp(projectDirectory, 'my-app');
+    generateReactApp(projectDirectory, appName);
     // Create the configuration
     runCommand(
-      'npx nx g nx-github-pages:configuration --user.name deployment-bot --user.email deployment@testing.com  --project my-app --no-interactive',
+      `npx nx g nx-github-pages:configuration --user.name deployment-bot --user.email deployment@testing.com --project ${nxProjectName} --no-interactive`,
       projectDirectory,
       {}
     );
     // Initial deployment
-    runCommand('npx nx deploy my-app --no-interactive', projectDirectory, {});
-    // enable sync settings
-    updateJsonFile<ProjectConfiguration>(
+    runCommand(
+      `npx nx deploy ${nxProjectName} --no-interactive`,
       projectDirectory,
-      'apps/my-app/project.json',
-      (json) => {
-        json.targets.deploy.options.syncWithBaseBranch = true;
-        json.targets.deploy.options.syncGitOptions = [
-          '--allow-unrelated-histories',
-          '-s ours',
-        ];
-        return json;
-      }
+      {}
     );
-    // Update the app
-    updateFile(projectDirectory, 'apps/my-app/src/index.html', (content) =>
+    // enable sync settings — Nx 22+ stores project config in package.json under "nx"
+    const projectConfigPath = existsSync(
+      join(projectDirectory, `apps/${appName}/project.json`)
+    )
+      ? `apps/${appName}/project.json`
+      : `apps/${appName}/package.json`;
+    const isPackageJson = projectConfigPath.endsWith('package.json');
+
+    if (isPackageJson) {
+      updateJsonFile<{ nx: ProjectConfiguration }>(
+        projectDirectory,
+        projectConfigPath,
+        (json) => {
+          json.nx.targets.deploy.options.syncWithBaseBranch = true;
+          json.nx.targets.deploy.options.syncGitOptions = [
+            '--allow-unrelated-histories',
+            '-s ours',
+          ];
+          return json;
+        }
+      );
+    } else {
+      updateJsonFile<ProjectConfiguration>(
+        projectDirectory,
+        projectConfigPath,
+        (json) => {
+          json.targets.deploy.options.syncWithBaseBranch = true;
+          json.targets.deploy.options.syncGitOptions = [
+            '--allow-unrelated-histories',
+            '-s ours',
+          ];
+          return json;
+        }
+      );
+    }
+    // Update the app — Nx 22+ with Vite puts index.html at the app root
+    const indexHtmlPath = existsSync(
+      join(projectDirectory, `apps/${appName}/index.html`)
+    )
+      ? `apps/${appName}/index.html`
+      : `apps/${appName}/src/index.html`;
+    updateFile(projectDirectory, indexHtmlPath, (content) =>
       content.replace(
         '<div id="root"></div>',
         '<h1>Updated</h1><div id="root"></div>'
@@ -80,7 +122,11 @@ describe('nx-github-pages', () => {
 
     // TEST
     // Deploy the updated app
-    runCommand('npx nx deploy my-app --no-interactive', projectDirectory, {});
+    runCommand(
+      `npx nx deploy ${nxProjectName} --no-interactive`,
+      projectDirectory,
+      {}
+    );
 
     // ASSERT
     // Check that the gh-pages branch exists in the remote
@@ -112,7 +158,7 @@ function createTestProject(remote: string) {
   });
 
   execSync(
-    `npx --yes create-nx-workspace@latest ${projectName} --preset apps --nxCloud=skip --no-interactive`,
+    `npx --yes create-nx-workspace@latest ${projectName} --preset apps --nxCloud=skip --skipGit --no-interactive`,
     {
       cwd: dirname(projectDirectory),
       stdio: 'inherit',
@@ -217,6 +263,17 @@ function updateJsonFile<T>(
   });
 }
 
+function getNxProjectName(
+  projectDirectory: string,
+  appName: string
+): string {
+  const pkgJson = JSON.parse(
+    readFileSync(join(projectDirectory, 'package.json'), 'utf-8')
+  );
+  const scopeMatch = (pkgJson.name as string)?.match(/^(@[^/]+)\//);
+  return scopeMatch ? `${scopeMatch[1]}/${appName}` : appName;
+}
+
 function generateReactApp(projectDirectory: string, projectName: string) {
   runCommand(
     `npx nx g @nx/react:app ${projectName} --directory apps/${projectName} --projectNameAndRootFormat=as-provided --e2eTestRunner none --unitTestRunner none --linter none --no-interactive`,

packages/e2e/src/nx-github-pages.spec.ts

@@ -3,7 +3,6 @@
  * It is meant to be called in jest's globalSetup.
  */
 import { startLocalRegistry } from '@nx/js/plugins/jest/local-registry';
-import { execFileSync } from 'child_process';
 import { releasePublish, releaseVersion } from 'nx/release';
 
 export default async () => {
@@ -24,7 +23,7 @@ export default async () => {
     gitCommit: false,
     gitTag: false,
     firstRelease: true,
-    generatorOptionsOverrides: {
+    versionActionsOptionsOverrides: {
       skipLockFileUpdate: true,
     },
   });