Extend Helm chart with auto-migrate and extraVolumes options#147
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Gates the startup auto-migration behind a new AGENTEVALS_AUTO_MIGRATE environment variable (default true). When disabled, the server verifies the schema is clean and up-to-date and refuses to start otherwise. Also extends the Helm chart with extraVolumes / extraVolumeMounts pass-throughs and an autoMigrate value.
Changes:
- New
_env_boolhelper and gated migration path in lifespan, usingmigrator.status()+discover_migrations()to detect dirty/pending state. - Helm chart
values.yamlexposesextraVolumes,extraVolumeMounts, anddatabase.postgres.autoMigrate. deployment.yamlmerges extra volumes/mounts and setsAGENTEVALS_AUTO_MIGRATEenv var.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/agentevals/api/app.py | Adds env-bool parsing and conditional migrate-vs-verify startup logic. |
| charts/agentevals/values.yaml | Adds extraVolumes, extraVolumeMounts, and autoMigrate values with docs. |
| charts/agentevals/templates/deployment.yaml | Renders extra volumes/mounts and the new env var. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gates the existing startup migration call behind
AGENTEVALS_AUTO_MIGRATE(default true, refuse-to-start when false and schema is behind) and adds extraVolumes / extraVolumeMounts pass-throughs to the Helm chart.