Skip to content

Conversation

@frontegg-david
Copy link
Contributor

@frontegg-david frontegg-david commented Jan 16, 2026

Summary by CodeRabbit

  • Chores
    • Centralized server configuration for E2E demo applications with HTTP server, logging, and authentication settings.
    • Reorganized imports to source configuration from a shared module.
    • Updated default port for security test application from 3015 to 3122.

✏️ Tip: You can customize this high-level summary in your review settings.

@frontegg-david frontegg-david changed the base branch from main to release/0.8.x January 16, 2026 01:10
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR introduces a centralized server configuration module for the demo-e2e-direct app by extracting the previously local serverConfig constant into a dedicated config.ts file. Import sources are updated accordingly to reference the new module, and the default port for the security test OpenAPI app is changed from 3015 to 3122.

Changes

Cohort / File(s) Summary
Configuration Extraction
apps/e2e/demo-e2e-direct/src/config.ts, apps/e2e/demo-e2e-direct/src/main.ts, apps/e2e/demo-e2e-direct/src/stdio-entrypoint.ts
New centralized config module created; main.ts refactored to import and re-export serverConfig; stdio-entrypoint.ts import source changed from main.js to config.js to prevent HTTP server auto-bootstrap.
Port Configuration Update
apps/e2e/demo-e2e-openapi/src/security-test-main.ts
Default port changed from 3015 to 3122 (with process.env override still available).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Configuration scattered far and wide,
Now centralized with bundled pride!
Imports dance a new ballet,
Ports adjusted in their way.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title 'Fix remote mcp test' is vague and does not clearly indicate the full scope of changes, which include extensive documentation updates, config file modifications, port reconfigurations across 25+ demo apps, and workflow adjustments. Consider a more specific title that reflects the primary changes, such as 'Reorganize docs structure and update demo app port configurations' or similar that better represents the substantial nature of the changeset.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f62b790 and 283feb1.

📒 Files selected for processing (4)
  • apps/e2e/demo-e2e-direct/src/config.ts
  • apps/e2e/demo-e2e-direct/src/main.ts
  • apps/e2e/demo-e2e-direct/src/stdio-entrypoint.ts
  • apps/e2e/demo-e2e-openapi/src/security-test-main.ts

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@frontegg-david frontegg-david merged commit 1c2493c into release/0.8.x Jan 16, 2026
3 of 4 checks passed
@frontegg-david frontegg-david deleted the fix-remote-mcp-test branch January 16, 2026 01:23
github-actions bot pushed a commit that referenced this pull request Jan 16, 2026
Cherry-picked from #216 (merged to release/0.8.x)
Original commit: 1c2493c

Co-Authored-By: frontegg-david <69419539+frontegg-david@users.noreply.github.com>
@github-actions
Copy link
Contributor

Cherry-pick Created

A cherry-pick PR to main has been automatically created.

Please review and merge if this change should also be in main.

If the cherry-pick is not needed, close the PR.

frontegg-david added a commit that referenced this pull request Jan 16, 2026
Cherry-picked from #216 (merged to release/0.8.x)
Original commit: 1c2493c

Co-authored-by: agentfront[bot] <agentfront[bot]@users.noreply.github.com>
Co-authored-by: frontegg-david <69419539+frontegg-david@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants