feat: graph UI: edit tags and metadata in detail panel#28
Merged
spokV merged 2 commits intoagentic-box:devfrom Mar 13, 2026
Merged
feat: graph UI: edit tags and metadata in detail panel#28spokV merged 2 commits intoagentic-box:devfrom
spokV merged 2 commits intoagentic-box:devfrom
Conversation
bb661cd to
ca7e06c
Compare
spokV
approved these changes
Mar 13, 2026
Collaborator
spokV
left a comment
There was a problem hiding this comment.
LGTM — solid feature addition. Inline tag/metadata editing works well through the UI. A few follow-up items worth addressing (opening as issues):
escapeHtmlText()doesn't escape quotes — attribute injection possible in tag/metadata editor inputs- PATCH endpoints replace metadata entirely instead of merging with existing keys
- Cloudflare PATCH bypasses tag whitelist validation (local server is protected)
rerenderPanelDraft()writes draft intomemoryCache, so Cancel shows stale draftrun-memora-graph.shhardcodes.venv/bin/memora-serverandsource ~/.bashrc
None are blockers — the UI sends full objects so data loss doesn't occur in practice, and the graph UI isn't public-facing.
This was referenced Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Add editable tags and metadata to the graph detail panel
Summary
This PR adds per-entry tag and metadata editing to the live graph UI. The detail panel now shows read-only scalar metadata, separates complex metadata into its own block, and supports inline editing of tags and scalar key/value metadata with save/cancel controls.
The change also unifies the update flow behind
PATCH /api/memories/{id}for both the local graph server and the Cloudflare Pages endpoint, so the UI can persist tags, metadata, and favorite state through one consistent API.What changed
Graph detail panel:
Edit,Save, andCancelcontrolsGraph update API:
PATCH /api/memories/{id}Validation/testing:
404Implementation notes
Editable metadata is limited to scalar values in this PR:
stringnumberbooleannullComplex metadata such as arrays/objects remains visible but read-only.
imagesis treated as reserved/system-managed and is excluded from inline editing.Tag edits still respect the existing backend whitelist.
Browser validation
I also exercised the feature end-to-end in the live graph UI with Playwright on an isolated worktree-specific graph URL. That surfaced and fixed two frontend issues:
memoryCacheTesting
python3 -m py_compile memora/graph/server.py tests/test_graph_server.pypython3 -m pytest tests/test_graph_server.py -qNotes / follow-up