Full scan for find_referenced_symbols#126
Merged
robmck1995 merged 3 commits intomainfrom Feb 17, 2025
Merged
Conversation
Contributor
Pull Request Feedback 🔍
|
| let (_, references_to_symbols) = match self | ||
| .ast_grep | ||
| .get_symbol_and_references(full_path_str, &position, false) | ||
| .get_symbol_and_references(full_path_str, &position, full_scan) |
Contributor
There was a problem hiding this comment.
Suggestion: Consider logging the value of full_scan for debugging purposes to help trace its usage and effects. [enhancement]
Suggested change
| .get_symbol_and_references(full_path_str, &position, full_scan) | |
| log::debug!("full_scan value: {}", full_scan); | |
| .get_symbol_and_references(full_path_str, &position, full_scan) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeAnt-AI Description
full_scanoption to theGetReferencedSymbolsRequestto allow more comprehensive symbol searches.AstGrepClientto handlefull_scanusing theall-referencesrule.all-referencesin C#, Python, and TSX, and removed thenon-functionrule for Python.full_scanparameter.Changes walkthrough
9 files
api_types.rs
Add `full_scan` field to `GetReferencedSymbolsRequest`lsproxy/src/api_types.rs
full_scanboolean field toGetReferencedSymbolsRequest.full_scan.client.rs
Update reference filtering logic with `full_scan` supportlsproxy/src/ast_grep/client.rs
full_scanandall-referencesrule.find_referenced_symbols.rs
Pass `full_scan` parameter to symbol finding functionlsproxy/src/handlers/find_referenced_symbols.rs
full_scanparameter tofind_referenced_symbolsfunction.full_scanparameter.manager.rs
Add `full_scan` parameter to LSP manager methodslsproxy/src/lsp/manager/manager.rs
full_scanparameter tofind_referenced_symbolsmethod.get_symbol_and_referenceswithfull_scan.all-references.yml
Add `all-references` rule for C# identifierslsproxy/src/ast_grep/reference/rules/csharp/all-references.yml
all-referencesin C#.all-references.yml
Add `all-references` rule for Python identifierslsproxy/src/ast_grep/reference/rules/python/all-references.yml
all-referencesin Python.non-function.yml
Remove `non-function` rule for Python identifierslsproxy/src/ast_grep/reference/rules/python/non-function.yml
non-functionrule for Python identifiers.all-references.yml
Add `all-references` rule for TSX identifierslsproxy/src/ast_grep/reference/rules/tsx/all-references.yml
all-referencesin TSX.local-variable.yml
Add local variable rule for C# identifierslsproxy/src/ast_grep/symbol/rules/csharp/local-variable.yml
1 files
.csproj
Add C# project configuration filesample_project/csharp/.csproj
💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.