chore: hygiene thread — CI gofumpt, doc counts, omitempty, dedup, dead code#124
Merged
jamestexas merged 2 commits intomainfrom Mar 23, 2026
Merged
chore: hygiene thread — CI gofumpt, doc counts, omitempty, dedup, dead code#124jamestexas merged 2 commits intomainfrom
jamestexas merged 2 commits intomainfrom
Conversation
…d code - Add gofumpt format check to CI lint job [mache-7ik] - Update tool count: 9 → 15 in ARCHITECTURE.md and README.md [mache-5c9c0c] - Remove omitempty from content_template to preserve serialization [mache-5caf12] - Extract ensureFile() helper, dedup 3 os.Stat+IsDir checks [mache-qqr] - Remove reflect fallback in json_walker Values() — dead code [mache-uza]
There was a problem hiding this comment.
Pull request overview
This PR is a hygiene sweep that tightens formatting enforcement in CI, refreshes documentation to reflect the current MCP tool surface, and simplifies a few ingestion/code paths (file checks and JSON walking).
Changes:
- Add a gofumpt formatting check to the CI lint job.
- Update README/architecture docs to reflect 15 MCP tools and improve markdown formatting.
- Refactor ingestion file validation into a shared helper and remove dead reflection fallback from
JsonWalkermatches.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ci.yml |
Adds a gofumpt-based formatting check to the lint job. |
README.md |
Updates MCP tool count/list and minor markdown formatting tweaks. |
docs/ARCHITECTURE.md |
Updates MCP tool list/count and reformats tables/sections. |
internal/ingest/engine.go |
Extracts ensureFile() and deduplicates repeated file/dir checks. |
internal/ingest/json_walker.go |
Removes reflect-based map fallback in Values() and drops the reflect import. |
api/schema.go |
Removes omitempty from content_template so it always serializes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Enable pipefail in CI gofumpt step so errors aren't masked - ensureFile returns os.FileInfo to eliminate double stat in ingestRawFile - Fix stale "9 tool handlers" in ARCHITECTURE.md key file reference table [mache-7ik, mache-qqr, mache-5c9c0c]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mache-7ik)mache-5c9c0c)omitemptyfromcontent_templateto preserve JSON serialization (mache-5caf12)ensureFile()helper, dedup 3 identicalos.Stat+IsDirchecks in engine.go (mache-qqr)reflectfallback injson_walker.Values()(mache-uza)mache-5df546): already clean, closing as-isTest plan
task build— compiles cleantask test— all tests passCloses: mache-7ik, mache-5c9c0c, mache-5caf12, mache-qqr, mache-uza, mache-5df546