feat: string template functions for projection schemas#134
Merged
jamestexas merged 2 commits intomainfrom Mar 25, 2026
Merged
Conversation
…plit, join, hasPrefix, hasSuffix, trimPrefix, trimSuffix
Extends the schema FuncMap with standard string ops needed for
projection schemas (trivy-db, osv-scanner). join takes sep as first
arg so it works in pipelines: {{split .s ":" | join ", "}}.
19 tests, all TDD.
[mache-996aaf]
There was a problem hiding this comment.
Pull request overview
Adds common string manipulation helpers to the ingestion template FuncMap so projection schemas (e.g., trivy-db/osv-scanner) can transform fields like namespaces into bucket/path-friendly names.
Changes:
- Extend
tmplFuncswith 10 string functions:replace,lower,upper,title,split,join,hasPrefix,hasSuffix,trimPrefix,trimSuffix - Implement
join(sep, parts)to work naturally in template pipelines and to accept both[]stringand JSON-parsed[]any - Add a dedicated test suite covering the new functions and pipeline composition
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/ingest/engine.go | Adds the new string template functions to the shared tmplFuncs map (used by RenderTemplate) |
| internal/ingest/template_funcs_test.go | New tests validating each added function plus pipeline chaining and []any handling for join |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nt, rename test - title func: replace deprecated strings.Title with cases.Title(language.Und) - join comment: fix arg order to match signature (sep, parts) - Rename TestTemplateFuncs_SplitJoinReplace → SplitJoin (accurate name) [mache-996aaf]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replace,lower,upper,title,split,join,hasPrefix,hasSuffix,trimPrefix,trimSuffixjointakes sep as first arg so it works in pipelines:{{split .s ":" | join ", "}}Test plan
task lint— 0 issuestask test— full suite greenBead: mache-996aaf
🤖 Generated with Claude Code