refactor(graph): decompose sqlite_graph.go via /evolve [mache-13f80f + mache-140be5 + mache-141c81 + mache-143454]#396
Merged
jamestexas merged 1 commit intoMay 19, 2026
Conversation
Pure-move + structural simplification of internal/graph/sqlite_graph.go (1598 → 547 LOC) across 5 files. Net +68 LOC (file header overhead). New files: - sqlite_graph_scan.go (353) — lazy directory scanning + field extraction (mache-13f80f) - sqlite_graph_refs.go (434) — refs/defs sidecar (mache-140be5) - sqlite_graph_callees.go (215) — GetCallees with 4-level token resolution (mache-141c81) - sqlite_graph_schema.go (117) — schema walk utilities (mache-143454) sqlite_graph.go retains: OpenSQLiteGraph constructor, ListChildren / GetNode / ListChildStats legacy scan paths (use private fields), resolveContent (field-coupled to private state). Discipline: shipped via /rosary:evolve --simplify --focus internal/graph/sqlite_graph.go (the first /evolve-driven decomposition this campaign). Generator: principal-agent. Evaluator: skeptic-agent — re-ran all verify commands independently, verified the 110-line coverage-gate flag is a false positive (dissimilarity-index handling gap, filed as mache-301daf). API preserved (35 methods + constructor + type), 75.2% baseline coverage preserved, -race -count=2 clean. Closes mache-13f80f, mache-140be5, mache-141c81, mache-143454.
find_smells (advisory)Scoped to files changed in this PR. Rules below run on the standalone (no-LLO) cross-ref tables; fan_out_skew — 3 finding(s) in changed files
Rules: see |
4 tasks
jamestexas
added a commit
that referenced
this pull request
May 19, 2026
…_graph for trunk-vs-main gate PR #396 (sqlite_graph decomposition) verified 110 flagged lines as pre-existing-uncovered via skeptic-agent spot-checks against base. The --cached gate invocation against the PR's merge base exited 0 at the time, so annotations weren't added. At cumulative trunk-vs-main the same 110 lines surface again. This commit retroactively annotates them with the same pattern PR #398 (engine.go, 342 annotations) and PR #399 (find-smells, 30) used. All annotated lines reference mache-89b5dd (post-decomposition annotation-reduction campaign).
jamestexas
added a commit
that referenced
this pull request
May 19, 2026
…_graph for trunk-vs-main gate PR #396 (sqlite_graph decomposition) verified 110 flagged lines as pre-existing-uncovered via skeptic-agent spot-checks against base. The --cached gate invocation against the PR's merge base exited 0 at the time, so annotations weren't added. At cumulative trunk-vs-main the same 110 lines surface again. This commit retroactively annotates them with the same pattern PR #398 (engine.go, 342 annotations) and PR #399 (find-smells, 30) used. All annotated lines reference mache-89b5dd (post-decomposition annotation-reduction campaign).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First /evolve-driven decomposition this campaign. `--simplify --focus internal/graph/sqlite_graph.go`.
Generator: rosary:principal-agent. Evaluator: rosary:skeptic-agent (re-ran ALL verify commands independently). 4 ephemeral beads filed by scoping-agent, addressed in this PR.
sqlite_graph.go: 1598 → 547 LOC across 5 files. API preserved. Coverage 75.2% (baseline). Race -count=2 clean. task check exit 0.
Coverage-gate exit 1 with 110 lines is a VERIFIED FALSE POSITIVE — gate's diff parser treats dissimilarity index 62% as net-new, lines were uncovered on BASE too. Filed mache-301daf against tools/coverage-gate.
Skeptic-agent verdict: PASS. Closes mache-13f80f, mache-140be5, mache-141c81, mache-143454.