fix: skip large/binary files during ingestion (OOM guard)#68
Merged
jamestexas merged 1 commit intomainfrom Mar 6, 2026
Merged
Conversation
Add centralized ShouldSkipFile() with extension blocklist (.db, .sqlite, .zip, .png, etc.) and configurable size limit (default 100MB). New --max-file-size flag (e.g. "1GB", "0" to disable). ParseSize() handles human-readable strings. Applied consistently in both engine.go walk and mount.go schema inference walk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShouldSkipFile()with extension blocklist (.db,.sqlite,.zip,.png, etc.) and configurable size limit--max-file-sizeflag (default100MB,0to disable) with human-readableParseSize()engine.godirectory walk andmount.goschema inference walk.db)Test plan
TestShouldSkipFile— extension blocklist, size limit, zero-disablesTestParseSize— MB/GB/KB/bare number/invalid input./internal/ingest/...test suite passesmache mount ../venturi --schema go.jsonwith 10GB db in directory🤖 Generated with Claude Code