fix: Support structured memory config in agent YAML #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the memory field in agent configs only accepted a simple
string format like "File:./path.json". Users wanted to use a more
explicit structured format with type and config fields:
memory:
type: File
config:
path: ./k8s-helper-memory.json
max_messages: 50
This change adds a MemorySpec enum that supports both formats:
- Simple string: "File:./path.json" (backward compatible)
- Structured: {type: File, config: {path: ..., max_messages: ...}}
Changes:
- Add MemorySpec and StructuredMemoryConfig types in aof-core
- Update AgentConfig, AgentSpec, and FlatAgentConfig to use MemorySpec
- Update runtime.rs to handle the new MemorySpec type
- Add Display trait for MemorySpec for pretty printing
- Add comprehensive tests for both formats
- Update documentation with new structured format examples
Fixes #84
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add support for a new tool format that uses explicit type declarations:
tools:
- type: Shell
config:
allowed_commands: [kubectl, helm]
working_directory: /tmp
- type: MCP
config:
name: kubectl-mcp
command: ["npx", "-y", "@modelcontextprotocol/server-kubectl"]
- type: HTTP
config:
base_url: http://localhost:8080
This format is more explicit and follows Kubernetes-style conventions.
Changes:
- Add TypeBasedToolSpec struct with Shell/MCP/HTTP types
- Add TypeBasedToolType enum
- Update ToolSpec enum to support TypeBased variant
- Add helper methods: is_http(), is_shell(), tool_type(), type_based_spec()
- Add 4 new tests for type-based tool parsing
- Update documentation with new format examples
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add a note explaining the three supported tool specification formats:
- Type-based: {type: Shell, config: {...}}
- Simple: - shell
- Qualified: {name: shell, source: builtin, config: {...}}
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Now the runtime can actually process type-based tool specifications:
tools:
- type: Shell
config:
allowed_commands: [kubectl, helm]
- type: MCP
config:
name: kubectl-mcp
command: ["npx", "-y", "@server-kubectl"]
- type: HTTP
config:
base_url: http://localhost
Changes:
- Add AgentConfig methods for type-based tools:
- type_based_shell_tools(), type_based_mcp_tools(), type_based_http_tools()
- has_type_based_tools()
- type_based_mcp_to_server_configs() - converts to McpServerConfig
- shell_tool_config(), http_tool_config() - extract typed configs
- Add ShellToolConfig and HttpToolConfig structs
- Update runtime to detect and process type-based tools:
- Shell tools: adds shell + allowed_commands to executor
- MCP tools: converts to MCP server configs and initializes
- HTTP tools: adds http tool to executor
- Export new types from aof-core
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #84 - Agent Config Parser Error: memory field type mismatch
The memory field in agent configs now supports both simple string format (backward compatible) and structured object format:
Simple String Format (existing)
Structured Object Format (new)
Changes
MemorySpecenum supporting both simple string and structured formatsStructuredMemoryConfigstruct for the object formatmemory_type(),path(),max_messages(),is_file(),is_in_memory()Displaytrait for pretty printingcreate_memory_async()to handleMemorySpecTesting
Backward Compatibility
✅ Fully backward compatible. Existing configurations using string format continue to work.
🤖 Generated with Claude Code