fix: allow max_retries to be 0 to disable retries#469
Merged
mikehostetler merged 1 commit intoFeb 27, 2026
Conversation
Change max_retries type from :pos_integer to :non_neg_integer so users can set it to 0 to disable retry attempts for transient network errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
armanm
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change max_retries type from
:pos_integerto:non_neg_integerso users can set it to 0 to disable retry attempts for transient network errors.The reason I'd like to disable automatic transient error retries is to have control over how timeouts are handled. Some generations can take 5+ minutes and I'm not sure Req's
put_aws_sig_v4regenerates the signature on timeout retries, so eventually it hits a 403 with a signature error like this:I'd rather have timeouts not be retried and instead rely on Oban retry limits. Req already supports
max_retries: 0, so I think it makes sense to allow that.Type of Change
Breaking Changes
Testing
mix test)mix quality)Checklist
CHANGELOG.md(it is auto-generated by git_ops)Related Issues
Closes #