fix: Fix reasoning_effort not being passed through to OpenAI Chat Completion API#753
Merged
mikehostetler merged 1 commit intoJun 4, 2026
Conversation
Contributor
|
Thanks for the contribution here. The implementation is directionally right, the PR is merge-clean, and CI is green. I marked this |
755aa52 to
214fe82
Compare
Contributor
Author
|
@mikehostetler Thanks for taking a look. I force-pushed an update adding a test in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is in the same vein as #244. While testing Groq, I noticed that
reasoning_effortwas not getting passed through and sent to the Chat Completions API for GPT OSS models. The ChatAPI module was retrievingreasoning_effortfrom provider options, but it is a global common option that appears to be handled almost exclusively as a top-level option, not a provider option.Type of Change
Breaking Changes
I don't think this is a breaking change as it didn't appear to work as documented in the first place.
Testing
mix test)mix quality)Checklist
CHANGELOG.md(it is auto-generated by git_ops)Related Issues
#244